From issues-return-191848-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jun 2 17:35:08 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 683D6180667 for ; Tue, 2 Jun 2020 19:35:08 +0200 (CEST) Received: (qmail 75759 invoked by uid 500); 2 Jun 2020 17:35:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 75725 invoked by uid 99); 2 Jun 2020 17:35:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2020 17:35:04 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5194AE30AF for ; Tue, 2 Jun 2020 17:35:03 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id DF83D780C45 for ; Tue, 2 Jun 2020 17:35:00 +0000 (UTC) Date: Tue, 2 Jun 2020 17:35:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-23516) Store hive replication policy execution metrics in the relational DB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23516?focusedWorklogId=440341&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-440341 ] ASF GitHub Bot logged work on HIVE-23516: ----------------------------------------- Author: ASF GitHub Bot Created on: 02/Jun/20 17:34 Start Date: 02/Jun/20 17:34 Worklog Time Spent: 10m Work Description: aasha commented on a change in pull request #1044: URL: https://github.com/apache/hive/pull/1044#discussion_r434052580 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricCollector.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.parse.repl.metric; + +import org.apache.hadoop.hive.ql.parse.SemanticException; +import org.apache.hadoop.hive.ql.parse.repl.metric.event.ReplicationMetric; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +/** + * MetricCollector. + * In memory collection of metrics + */ +public class MetricCollector { + private Logger LOG = LoggerFactory.getLogger(MetricCollector.class); + private Map metricMap = new ConcurrentHashMap<>(); + private final long maxSize; + + private static volatile MetricCollector instance; + + private MetricCollector(long maxSize){ + this.maxSize = maxSize; + } + + public static MetricCollector getInstance(long maxSize) { Review comment: I can add a init method but the problem with that is it can be overwritten and we don't want that ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 440341) Time Spent: 2h (was: 1h 50m) > Store hive replication policy execution metrics in the relational DB > -------------------------------------------------------------------- > > Key: HIVE-23516 > URL: https://issues.apache.org/jira/browse/HIVE-23516 > Project: Hive > Issue Type: Task > Reporter: Aasha Medhi > Assignee: Aasha Medhi > Priority: Major > Labels: pull-request-available > Attachments: HIVE-23516.01.patch, HIVE-23516.02.patch, Replication Metrics.pdf > > Time Spent: 2h > Remaining Estimate: 0h > > Details documented in the attached doc -- This message was sent by Atlassian Jira (v8.3.4#803005)