hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <>
Subject [jira] [Work logged] (HIVE-23671) MSCK repair should handle transactional tables in certain usecases
Date Fri, 26 Jun 2020 11:45:00 GMT


ASF GitHub Bot logged work on HIVE-23671:

                Author: ASF GitHub Bot
            Created on: 26/Jun/20 11:44
            Start Date: 26/Jun/20 11:44
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on a change in pull request #1087:

File path: ql/src/test/org/apache/hadoop/hive/ql/
@@ -162,9 +163,23 @@ protected String getWarehouseDir() {
    * takes raw data and turns it into a string as if from Driver.getResults()
    * sorts rows in dictionary order
-  List<String> stringifyValues(int[][] rowsIn) {
-    return TestTxnCommands2.stringifyValues(rowsIn);
+  public static List<String> stringifyValues(int[][] rowsIn) {
+    assert rowsIn.length > 0;
+    int[][] rows = rowsIn.clone();
+    Arrays.sort(rows, new TestTxnCommands2.RowComp());

Review comment:
       move RowComp from TestTxnCommands2 to TxnCommandsBaseForTests

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 451512)
    Time Spent: 1h 20m  (was: 1h 10m)

> MSCK repair should handle transactional tables in certain usecases
> ------------------------------------------------------------------
>                 Key: HIVE-23671
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Peter Varga
>            Assignee: Peter Varga
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
> The MSCK REPAIR tool does not handle transactional tables too well. It can find and add
new partitions the same way as for non-transactional tables, but since the writeId differences
are not handled, the data can not read back from the new partitions.
> We could handle some usecases when the writeIds in the HMS and the underlying data are
not conflicting. If the HMS does not contains allocated writes for the table we can seed the
table with the writeIds read from the directory structrure.
> Real life use cases could be:
>  * Copy data files from one cluster to another with different HMS, create the table and
>  * If the HMS db is lost, recreate the table and call MSCK REPAIR

This message was sent by Atlassian Jira

View raw message