hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23629) Enforce clean findbugs in PRs
Date Mon, 08 Jun 2020 10:04:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23629?focusedWorklogId=442634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442634
]

ASF GitHub Bot logged work on HIVE-23629:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jun/20 10:03
            Start Date: 08/Jun/20 10:03
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #1069:
URL: https://github.com/apache/hive/pull/1069#issuecomment-640505232


   > > @pgaref The violations are available in pipeline logs. I have mixed feelings
about pushing back the results to associated Jira or to the PR. Previously these reports were
in the form of warning. It makes sense to push it back to JIra then, so people see them before
merging changes. Now, you cannot even get a test run without succeeding the report. So if
you have a green test run, you know that you did not introduce a new violation. If the pipeline
fails because of a new violation, it is easy enough to see the violations in pipeline logs.
Also the report becomes stale as soon as you push new changes. Personally, I really dont like
the clutter stale reports create on Jiras. Anyway, I think it is more important to introduce
this check as soon as possible. Reporting back can be introduced later if people really miss
it.
   > 
   > Agreed, lets introduce the check asap -- failing would also save us testing resources
as discussed. Reporting can be done as a next step.
   
   another approach which could be considered: publish the findbugs report in the build -
I think it will be there even if the build fails
   some of this might work:
   https://www.jenkins.io/doc/pipeline/steps/htmlpublisher/
   https://www.jenkins.io/blog/2017/02/10/declarative-html-publisher/
   I think it could be published in a "finally" block somewhere around compile...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 442634)
    Time Spent: 1h 10m  (was: 1h)

> Enforce clean findbugs in PRs
> -----------------------------
>
>                 Key: HIVE-23629
>                 URL: https://issues.apache.org/jira/browse/HIVE-23629
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We should start enforcing clean findbugs reports as soon as we fix a module. Otherwise,
it will continue collecting findbugs errors. We can add a stage to Jenkins pipeline to enforce
findbugs and possibly other checks. It will selectively run findbugs for specified sub modules.
Eventually we can get rid of the list and enable findbugs for the whole project.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message