hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23592) Routine "makeIntPair" is Not Correct
Date Mon, 15 Jun 2020 21:15:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23592?focusedWorklogId=446126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-446126
]

ASF GitHub Bot logged work on HIVE-23592:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jun/20 21:14
            Start Date: 15/Jun/20 21:14
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on a change in pull request #1052:
URL: https://github.com/apache/hive/pull/1052#discussion_r440255453



##########
File path: common/src/test/org/apache/hadoop/hive/common/TestNumberUtils.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.common;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+/**
+ * Test suite for the {@link NumberUtils} class.
+ */
+public class TestNumberUtils {
+
+  @Test
+  public void testMinLong() {
+    final long pair = NumberUtils.makeIntPair(Integer.MIN_VALUE, Integer.MIN_VALUE);
+    Assert.assertEquals(Integer.MIN_VALUE, NumberUtils.getFirstInt(pair));
+    Assert.assertEquals(Integer.MIN_VALUE, NumberUtils.getSecondInt(pair));
+  }
+
+  @Test
+  public void testMaxLong() {
+    final long pair = NumberUtils.makeIntPair(Integer.MAX_VALUE, Integer.MAX_VALUE);
+    Assert.assertEquals(Integer.MAX_VALUE, NumberUtils.getFirstInt(pair));
+    Assert.assertEquals(Integer.MAX_VALUE, NumberUtils.getSecondInt(pair));
+  }
+
+  @Test
+  public void testZeroLong() {
+    final long pair = NumberUtils.makeIntPair(0, 0);
+    Assert.assertEquals(0, NumberUtils.getFirstInt(pair));
+    Assert.assertEquals(0, NumberUtils.getSecondInt(pair));
+  }
+

Review comment:
       Please add some more tests with "everyday" positive and negative numbers, the current
tests prove only that it works fine fo the extreme values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 446126)
    Time Spent: 1.5h  (was: 1h 20m)

> Routine "makeIntPair" is Not Correct
> ------------------------------------
>
>                 Key: HIVE-23592
>                 URL: https://issues.apache.org/jira/browse/HIVE-23592
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> {code:java|title=BuddyAllocator.java}
>   // Utility methods used to store pairs of ints as long.
>   private static long makeIntPair(int first, int second) {
>     return ((long)first) << 32 | second;
>   }
>   private static int getFirstInt(long result) {
>     return (int) (result >>> 32);
>   }
>   private static int getSecondInt(long result) {
>     return (int) (result & ((1L << 32) - 1));
>   }
> {code}
> {code:java}
>     long result = LLAP.makeIntPair(Integer.MIN_VALUE, Integer.MIN_VALUE);
>     if (LLAP.getFirstInt(result) != Integer.MIN_VALUE) {
>        throw new Exception();
>     }
>     if (LLAP.getSecondInt(result) != Integer.MIN_VALUE) {
>       throw new Exception();
>    }
> /*
>  * Exception in thread "main" java.lang.Exception
>  * 	at org.test.TestMe.main(TestMe.java:19)
>  */
> {code}
> [https://github.com/apache/hive/blob/4b670877c280b37c5776046f66d766079489b2a8/llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java#L1677]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message