hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-23499) REPL: Immutable repl dumps should be reusable across multiple repl loads
Date Fri, 12 Jun 2020 07:45:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-23499?focusedWorklogId=444750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444750
]

ASF GitHub Bot logged work on HIVE-23499:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/20 07:44
            Start Date: 12/Jun/20 07:44
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #1092:
URL: https://github.com/apache/hive/pull/1092#discussion_r439260449



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -309,7 +310,9 @@ a database ( directory )
     // Populate the driver context with the scratch dir info from the repl context, so that
the
     // temp dirs will be cleaned up later
     context.getFsScratchDirs().putAll(loadContext.pathInfo.getFsScratchDirs());
-    createReplLoadCompleteAckTask();
+    if (!HiveConf.getBoolVar(conf, REPL_DUMP_SKIP_IMMUTABLE_DATA_COPY)) {

Review comment:
       Please add a test for this. You can do a acknolegment check in the same REPL_DUMP_SKIP_IMMUTABLE_DATA_COPY
testcase also




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 444750)
    Time Spent: 0.5h  (was: 20m)

> REPL: Immutable repl dumps should be reusable across multiple repl loads
> ------------------------------------------------------------------------
>
>                 Key: HIVE-23499
>                 URL: https://issues.apache.org/jira/browse/HIVE-23499
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23499.1.patch, HIVE-23499.2.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> "{{hive.repl.dump.metadata.only=true"}} is not currently honored during "{{repl load"}}.
Currently, it ends up copying all files even if this option is specified in "repl load". 
E.g
> {noformat}
> repl load airline_ontime_orc into another_airline_ontime_orc with ('hive.repl.rootdir'='s3a://blah/',
'hive.repl.dump.metadata.only'='true'); {noformat}
> Alternatively, we can use {{hive.repl.dump.skip.immutable.data.copy}} and skip the load
ack file. This would enable users to reuse immutable repl dumps. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message