hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-17313) Potentially possible 'case fall through' in the ObjectInspectorConverters
Date Wed, 24 Jun 2020 00:26:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-17313?focusedWorklogId=450106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-450106
]

ASF GitHub Bot logged work on HIVE-17313:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/20 00:25
            Start Date: 24/Jun/20 00:25
    Worklog Time Spent: 10m 
      Work Description: github-actions[bot] closed pull request #230:
URL: https://github.com/apache/hive/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 450106)
    Time Spent: 20m  (was: 10m)

> Potentially possible 'case fall through' in the ObjectInspectorConverters
> -------------------------------------------------------------------------
>
>                 Key: HIVE-17313
>                 URL: https://issues.apache.org/jira/browse/HIVE-17313
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Oleg Danilov
>            Assignee: Oleg Danilov
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17313.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Lines 103-110:
> {code:java}
>     case STRING:
>       if (outputOI instanceof WritableStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.TextConverter(
>             inputOI);
>       } else if (outputOI instanceof JavaStringObjectInspector) {
>         return new PrimitiveObjectInspectorConverter.StringConverter(
>             inputOI);
>       }
>     case CHAR:
> {code}
> De-facto it should work correctly since outputOI is either an instance of WritableStringObjectInspector
or JavaStringObjectInspector, but it would be better to rewrite this case to avoid possible
fall through.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message