From issues-return-189216-archive-asf-public=cust-asf.ponee.io@hive.apache.org Mon May 11 12:41:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3B1BA180677 for ; Mon, 11 May 2020 14:41:03 +0200 (CEST) Received: (qmail 89907 invoked by uid 500); 11 May 2020 12:41:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 89824 invoked by uid 99); 11 May 2020 12:41:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 May 2020 12:41:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F02A5E2F0E for ; Mon, 11 May 2020 12:41:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 5BA8B7822B9 for ; Mon, 11 May 2020 12:41:00 +0000 (UTC) Date: Mon, 11 May 2020 12:41:00 +0000 (UTC) From: "Naveen Gangam (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-23316) Add tests to cover database managed location related DDL and fix minor issues MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23316?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1710= 4411#comment-17104411 ]=20 Naveen Gangam commented on HIVE-23316: -------------------------------------- My worry with using something like this ALTER DATABASE ... SET [MANAGED] LOCATION ... -> TOK_ALTERDATABASE_LOCATION is that we will have different syntax with CREATE DATABASE vs ALTER DATABAS= E CREATE DATABASE dbname LOCATION ... MANAGEDLOCATION ...;=20 We also had plans to support being able to set both LOCATION and MANAGEDLOC= ATION in a single SET statement as well and also have support in metatool t= o be able to modify both elements in a single go.=20 * Better usability with being able to run single DDL vs multiple. * Guarantees atomicity between the 2 operations. (Being able to swap manage= d and external locations on DB that were incorrectly set, or when users are= migrating old databases that have single location to use this new model) Should we abandon them? I dont know if it is much more efficient than setti= ng than separately. Thanks > Add tests to cover database managed location related DDL and fix minor is= sues > -------------------------------------------------------------------------= ---- > > Key: HIVE-23316 > URL: https://issues.apache.org/jira/browse/HIVE-23316 > Project: Hive > Issue Type: Bug > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Attachments: HIVE-23316.01.patch > > > Database managed location was recently introduced, but no tests were adde= d to cover it. also the following issues were fixed: > * ALTER DATABASE ... SET MANAGEDLOCATION ... commands were not handled i= n a separate path as it should, as in DDL each command type have their own = Analyzer, Desc, and Operation class > * in case of setting the LOCATION or the MANAGEDLOCATION the location wa= s not getting qualified as in the CREATE DATABASE command > * in case of=C2=A0setting the LOCATION or the MANAGEDLOCATION it was not= checked if this modification makes the two the same > * some minor checkstyle issues were fixed as well > Also the DDL documentation was not modified. -- This message was sent by Atlassian Jira (v8.3.4#803005)