From issues-return-189548-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed May 13 15:20:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E559818064A for ; Wed, 13 May 2020 17:20:01 +0200 (CEST) Received: (qmail 90451 invoked by uid 500); 13 May 2020 15:20:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 90425 invoked by uid 99); 13 May 2020 15:20:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2020 15:20:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9FB2CE069E for ; Wed, 13 May 2020 15:20:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1D45D78026D for ; Wed, 13 May 2020 15:20:00 +0000 (UTC) Date: Wed, 13 May 2020 15:20:00 +0000 (UTC) From: "David Mollitor (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-23099) Improve Logger for Operation Child Classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated HIVE-23099: ---------------------------------- Attachment: HIVE-23099.5.patch > Improve Logger for Operation Child Classes > ------------------------------------------ > > Key: HIVE-23099 > URL: https://issues.apache.org/jira/browse/HIVE-23099 > Project: Hive > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Attachments: HIVE-23099.1.patch, HIVE-23099.2.patch, HIVE-23099.3.patch, HIVE-23099.4.patch, HIVE-23099.4.patch, HIVE-23099.5.patch, HIVE-23099.5.patch > > > The {{Operation}} class declares its logger this way: > {code:java|title=Operation.java} > public abstract class Operation { > public static final Logger LOG = LoggerFactory.getLogger(Operation.class.getName()); > ... > } > {code} > Notice that this is an {{abstract}} class, but the {{Logger}} is tied to the {{Operation.class.getName()}}. This means that logging cannot be controlled for each subclass of {{Operation}} independently since they all use the same static {{Logger}} instance. > Make the LOG a {{protected}} instance variable that inherits the name of the child class. -- This message was sent by Atlassian Jira (v8.3.4#803005)