hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23461) Needs to capture input/output entities in explainRewrite
Date Wed, 27 May 2020 04:20:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117380#comment-17117380
] 

Hive QA commented on HIVE-23461:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13004078/HIVE-23461.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17286 tests executed
*Failed tests:*
{noformat}
org.apache.hive.beeline.TestBeeLineWithArgs.testRowsAffected (batchId=210)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/22637/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22637/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22637/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13004078 - PreCommit-HIVE-Build

> Needs to capture input/output entities in explainRewrite
> --------------------------------------------------------
>
>                 Key: HIVE-23461
>                 URL: https://issues.apache.org/jira/browse/HIVE-23461
>             Project: Hive
>          Issue Type: Bug
>          Components: Authorization
>            Reporter: Wenchao Li
>            Assignee: Naresh P R
>            Priority: Major
>         Attachments: HIVE-23461.patch
>
>
> HIVE-18778(CVE-2018-1314) capture input/output entitles in explain semantic analyzer
so when a query is disallowed by Ranger, Sentry or Sqlstd authorizizer, the corresponding
explain statement will be disallowed either.
> However, ExplainSQRewriteSemanticAnalyzer also uses an instance of DDLSemanticAnalyzer
to analyze the explain rewrite query.
> {code:java}
> SemanticAnalyzer sem = (SemanticAnalyzer)
>  SemanticAnalyzerFactory.get(queryState, input);
> sem.analyze(input, ctx);
> sem.validate();{code}
>  
> The inputs/outputs entities for this query are never set on the instance of ExplainSQRewriteSemanticAnalyzer
itself and thus is not propagated into the HookContext in the calling Driver code. It is a
similar issue to HIVE-18778.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message