hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23446) LLAP: Reduce IPC connection misses to AM for short queries
Date Thu, 14 May 2020 15:15:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107395#comment-17107395
] 

Hive QA commented on HIVE-23446:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 22s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 29s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 16s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 52s{color} | {color:blue}
llap-server in master has 87 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 19s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 29s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 29s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 29s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 17s{color} | {color:red}
llap-server: The patch generated 8 new + 54 unchanged - 3 fixed = 62 total (was 57) {color}
|
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m  2s{color} | {color:red}
llap-server generated 3 new + 85 unchanged - 2 fixed = 88 total (was 87) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 17s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 42s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-server |
|  |  Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored
in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String,
Token)  At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.getUmbilicalUgi(String,
Token)  At ContainerRunnerImpl.java:[line 656] |
|  |  Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored
in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String,
UserGroupInformation)  At ContainerRunnerImpl.java:ignored in org.apache.hadoop.hive.llap.daemon.impl.ContainerRunnerImpl$UgiPool.returnUmbilicalUgi(String,
UserGroupInformation)  At ContainerRunnerImpl.java:[line 672] |
|  |  new org.apache.hadoop.hive.llap.daemon.impl.QueryInfo(QueryIdentifier, String, String,
String, String, int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId,
String, Token, boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by
storing an externally mutable object into QueryInfo.localDirsBase  At QueryInfo.java:String,
int, String, ConcurrentMap, String[], FileSystem, String, String, LlapNodeId, String, Token,
boolean, ContainerRunnerImpl$UgiPool) may expose internal representation by storing an externally
mutable object into QueryInfo.localDirsBase  At QueryInfo.java:[line 91] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-22336/dev-support/hive-personality.sh
|
| git revision | master / 390ad7d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-22336/yetus/diff-checkstyle-llap-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-22336/yetus/new-findbugs-llap-server.html
|
| modules | C: llap-server U: llap-server |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-22336/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> LLAP: Reduce IPC connection misses to AM for short queries
> ----------------------------------------------------------
>
>                 Key: HIVE-23446
>                 URL: https://issues.apache.org/jira/browse/HIVE-23446
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Major
>         Attachments: HIVE-23446.1.patch, HIVE-23446.2.patch, HIVE-23446.3.patch
>
>
> [https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java#L343]
>  
> Umbilical UGI pool for is maintained at QueryInfo level. When there are lots of short
queries, this ends up missing IPC cache and ends up recreating threads/connections to the
same AM.
> It would be good to maintain this pool in {{ContainerRunnerImpl}} instead and recycle
as needed.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message