hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23389) FilterMergeRule can lead to AssertionError
Date Sun, 10 May 2020 18:52:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103914#comment-17103914
] 

Zoltan Haindrich commented on HIVE-23389:
-----------------------------------------

+1
I'm not sure if we want to follow the "Bug" concept - right now I don't think we have any
way to track these kind of things; but if the check would actually trigger some errors in
case the dependency is updated: that might be usefull...

> FilterMergeRule can lead to AssertionError
> ------------------------------------------
>
>                 Key: HIVE-23389
>                 URL: https://issues.apache.org/jira/browse/HIVE-23389
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-23389.01.patch, HIVE-23389.01.patch, HIVE-23389.02.patch, HIVE-23389.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> I have not been able to reproduce the issue in latest master. However, this could potentially
happen since Filter creation has a check on whether the expression is flat ([here|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/core/Filter.java#L74])
and Filter merge does not flatten an expression when it is created.
> {noformat}
> java.lang.AssertionError: AND(=($3, 100), OR(OR(null, IS NOT NULL(CAST(100):INTEGER)),
=(CAST(100):INTEGER, CAST(200):INTEGER)))
> 	at org.apache.calcite.rel.core.Filter.<init>(Filter.java:74)
> 	at org.apache.hadoop.hive.ql.optimizer.calcite.reloperators.HiveFilter.<init>(HiveFilter.java:39)
> 	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveFilterFactoryImpl.createFilter(HiveRelFactories.java:126)
> 	at org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelBuilder.filter(HiveRelBuilder.java:99)
> 	at org.apache.calcite.tools.RelBuilder.filter(RelBuilder.java:1055)
> 	at org.apache.calcite.rel.rules.FilterMergeRule.onMatch(FilterMergeRule.java:81)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message