hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naveen Gangam (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23316) Add tests to cover database managed location related DDL and fix minor issues
Date Mon, 11 May 2020 12:41:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104411#comment-17104411
] 

Naveen Gangam commented on HIVE-23316:
--------------------------------------

My worry with using something like this
ALTER DATABASE ... SET [MANAGED] LOCATION ... -> TOK_ALTERDATABASE_LOCATION

is that we will have different syntax with CREATE DATABASE vs ALTER DATABASE
CREATE DATABASE dbname LOCATION ... MANAGEDLOCATION ...; 

We also had plans to support being able to set both LOCATION and MANAGEDLOCATION in a single
SET statement as well and also have support in metatool to be able to modify both elements
in a single go. 
* Better usability with being able to run single DDL vs multiple.
* Guarantees atomicity between the 2 operations. (Being able to swap managed and external
locations on DB that were incorrectly set, or when users are migrating old databases that
have single location to use this new model)

Should we abandon them? I dont know if it is much more efficient than setting than separately.
Thanks

> Add tests to cover database managed location related DDL and fix minor issues
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-23316
>                 URL: https://issues.apache.org/jira/browse/HIVE-23316
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>         Attachments: HIVE-23316.01.patch
>
>
> Database managed location was recently introduced, but no tests were added to cover it.
also the following issues were fixed:
>  * ALTER DATABASE ... SET MANAGEDLOCATION ... commands were not handled in a separate
path as it should, as in DDL each command type have their own Analyzer, Desc, and Operation
class
>  * in case of setting the LOCATION or the MANAGEDLOCATION the location was not getting
qualified as in the CREATE DATABASE command
>  * in case of setting the LOCATION or the MANAGEDLOCATION it was not checked if this
modification makes the two the same
>  * some minor checkstyle issues were fixed as well
> Also the DDL documentation was not modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message