From issues-return-184792-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Apr 8 01:19:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4B24C180663 for ; Wed, 8 Apr 2020 03:19:03 +0200 (CEST) Received: (qmail 43043 invoked by uid 500); 8 Apr 2020 01:19:02 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 43033 invoked by uid 99); 8 Apr 2020 01:19:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2020 01:19:02 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 90722E044E for ; Wed, 8 Apr 2020 01:19:01 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 7ED287802FF for ; Wed, 8 Apr 2020 01:19:00 +0000 (UTC) Date: Wed, 8 Apr 2020 01:19:00 +0000 (UTC) From: "Hive QA (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-23114) Insert overwrite with dynamic partitioning is not working correctly with direct insert MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-23114?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1707= 7726#comment-17077726 ]=20 Hive QA commented on HIVE-23114: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 19s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 7m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 42s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 3= 8s{color} | {color:blue} ql in master has 1528 extant Findbugs warnings. {c= olor} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 53s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m = 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 4= 3s{color} | {color:red} ql: The patch generated 1 new + 313 unchanged - 1 f= ixed =3D 314 total (was 314) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m = 0s{color} | {color:red} The patch has 11 line(s) that end in whitespace. Us= e git apply --whitespace=3Dfix <>. Refer https://git-scm.com/do= cs/git-apply {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 53s= {color} | {color:red} ql generated 1 new + 1528 unchanged - 0 fixed =3D 152= 9 total (was 1528) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 51s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 15s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 30s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | The field org.apache.hadoop.hive.ql.exec.FileSinkOperator.dynamicPart= itionSpecs is transient but isn't set by deserialization In FileSinkOperat= or.java:but isn't set by deserialization In FileSinkOperator.java | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compi= le | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16= .43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21500/de= v-support/hive-personality.sh | | git revision | master / 189580e | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21500/yetu= s/diff-checkstyle-ql.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-21500/yetu= s/whitespace-eol.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21500/yetus/= new-findbugs-ql.html | | modules | C: ql itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21500/= yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Insert overwrite with dynamic partitioning is not working correctly with = direct insert > -------------------------------------------------------------------------= ------------- > > Key: HIVE-23114 > URL: https://issues.apache.org/jira/browse/HIVE-23114 > Project: Hive > Issue Type: Bug > Reporter: Marta Kuczora > Assignee: Marta Kuczora > Priority: Major > Attachments: HIVE-23114.1.patch, HIVE-23114.2.patch > > > This is a follow-up Jira for the [conversation|https://issues.apache.org/= jira/browse/HIVE-21164?focusedCommentId=3D17059280&page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel#comment-17059280] in=C2=A0H= IVE-21164 > Doing an insert overwrite from a multi-insert statement with dynamic par= titioning will give wrong results for ACID tables when 'hive.acid.direct.in= sert.enabled' is true or for insert-only tables. > Reproduction: > {noformat} > set hive.acid.direct.insert.enabled=3Dtrue; > set hive.support.concurrency=3Dtrue; > set hive.txn.manager=3Dorg.apache.hadoop.hive.ql.lockmgr.DbTxnManager; > set hive.vectorized.execution.enabled=3Dfalse; > set hive.stats.autogather=3Dfalse; > create external table multiinsert_test_text (a int, b int, c int) stored = as textfile; > insert into multiinsert_test_text values (1111, 11, 1111), (2222, 22, 111= 1), (3333, 33, 2222), (4444, 44, NULL), (5555, 55, NULL); > create table multiinsert_test_acid (a int, b int) partitioned by (c int) = stored as orc tblproperties('transactional'=3D'true'); > create table multiinsert_test_mm (a int, b int) partitioned by (c int) st= ored as orc tblproperties('transactional'=3D'true', 'transactional_properti= es'=3D'insert_only'); > from multiinsert_test_text a > insert overwrite table multiinsert_test_acid partition (c) > select > a.a, > a.b, > a.c > where a.c is not null > insert overwrite table multiinsert_test_acid partition (c) > select > a.a, > a.b, > a.c > where a.c is null; > select * from multiinsert_test_acid; > from multiinsert_test_text a > insert overwrite table multiinsert_test_mm partition (c) > select > a.a, > a.b, > a.c > where a.c is not null > insert overwrite table multiinsert_test_mm partition (c) > select > a.a, > a.b, > a.c > where a.c is null; > select * from multiinsert_test_mm; > {noformat} > The result of these steps can be different, it depends on the execution o= rder of the FileSinkOperators of the insert overwrite statements. It can ha= ppen that an error occurs due to manifest file collision, it can happen tha= t no error occurs but the result will be incorrect. > Running the same insert query with an external table of with and ACID ta= ble with 'hive.acid.direct.insert.enabled=3Dfalse' will give the follwing r= esult: > {noformat} > 1111 11 1111 > 2222 22 1111 > 3333 33 2222 > 4444 44 NULL > 5555 55 NULL > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)