From issues-return-184906-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Apr 8 21:01:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1E26D18057A for ; Wed, 8 Apr 2020 23:01:02 +0200 (CEST) Received: (qmail 57348 invoked by uid 500); 8 Apr 2020 21:01:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 57338 invoked by uid 99); 8 Apr 2020 21:01:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2020 21:01:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0375E2CF8 for ; Wed, 8 Apr 2020 21:01:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0C8207802B2 for ; Wed, 8 Apr 2020 21:01:00 +0000 (UTC) Date: Wed, 8 Apr 2020 21:01:00 +0000 (UTC) From: "Hive QA (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-22750) Consolidate LockType naming MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078705#comment-17078705 ] Hive QA commented on HIVE-22750: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12999344/HIVE-22750.12.patch {color:green}SUCCESS:{color} +1 due to 4 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 18192 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID.org.apache.hadoop.hive.ql.parse.TestStatsReplicationScenariosACID (batchId=262) org.apache.hadoop.hive.ql.schq.TestScheduledQueryStatements.testExecuteImmediate (batchId=359) org.apache.hive.jdbc.TestActivePassiveHA.testActivePassiveHA (batchId=292) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21517/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21517/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21517/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12999344 - PreCommit-HIVE-Build > Consolidate LockType naming > --------------------------- > > Key: HIVE-22750 > URL: https://issues.apache.org/jira/browse/HIVE-22750 > Project: Hive > Issue Type: Improvement > Components: Transactions > Reporter: Zoltan Chovan > Assignee: Marton Bod > Priority: Minor > Attachments: HIVE-22750.1.patch, HIVE-22750.10.patch, HIVE-22750.11.patch, HIVE-22750.12.patch, HIVE-22750.2.patch, HIVE-22750.3.patch, HIVE-22750.4.patch, HIVE-22750.5.patch, HIVE-22750.5.patch, HIVE-22750.6.patch, HIVE-22750.7.patch, HIVE-22750.8.patch, HIVE-22750.9.patch, HIVE-22750.9.patch, HIVE-22750.9.patch, HIVE-22750.9.patch > > > Extend enum with string literal to remove unnecessary `id` to `char` casting for the LockType: > {code:java} > switch (lockType) { > case EXCLUSIVE: > lockChar = LOCK_EXCLUSIVE; > break; > case SHARED_READ: > lockChar = LOCK_SHARED; > break; > case SHARED_WRITE: > lockChar = LOCK_SEMI_SHARED; > break; > } > {code} > Consolidate LockType naming in code and schema upgrade scripts: > {code:java} > CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN 'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE, > {code} > +*Lock types:*+ > EXCLUSIVE > EXCL_WRITE > SHARED_WRITE > SHARED_READ -- This message was sent by Atlassian Jira (v8.3.4#803005)