hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-23266) Remove QueryWrapper from ObjectStore
Date Tue, 28 Apr 2020 06:10:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-23266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094181#comment-17094181
] 

Hive QA commented on HIVE-23266:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 48s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 28s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 20s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 15s{color} | {color:blue}
standalone-metastore/metastore-server in master has 188 extant Findbugs warnings. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 19s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 32s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 26s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 26s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 20s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 15 new + 268 unchanged - 28 fixed
= 283 total (was 296) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 19s{color} | {color:red}
standalone-metastore/metastore-server generated 3 new + 187 unchanged - 1 fixed = 190 total
(was 188) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 19s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 14s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 49s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  Impossible cast from String to org.apache.hadoop.hive.metastore.model.MPartition in
org.apache.hadoop.hive.metastore.ObjectStore.listPartitionsPsWithAuth(String, String, String,
List, short, String, List)  At ObjectStore.java:org.apache.hadoop.hive.metastore.model.MPartition
in org.apache.hadoop.hive.metastore.ObjectStore.listPartitionsPsWithAuth(String, String, String,
List, short, String, List)  At ObjectStore.java:[line 3162] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table,
List, List, String)  At ObjectStore.java:is not thrown in org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table,
List, List, String)  At ObjectStore.java:[line 9142] |
|  |  org.apache.hadoop.hive.metastore.ObjectStore.getMPartitionColumnStatistics(Table, List,
List, String) concatenates strings using + in a loop  At ObjectStore.java:strings using +
in a loop  At ObjectStore.java:[line 9122] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21984/dev-support/hive-personality.sh
|
| git revision | master / ea74565 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21984/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-21984/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-21984/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server
|
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21984/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Remove QueryWrapper from ObjectStore
> ------------------------------------
>
>                 Key: HIVE-23266
>                 URL: https://issues.apache.org/jira/browse/HIVE-23266
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-23266.1.patch, HIVE-23266.2.patch, HIVE-23266.2.patch, HIVE-23266.3.patch,
HIVE-23266.4.patch
>
>
> There is currently a utility called {{QueryWrapper}} that makes a normal {{Query}} auto-closable.
 However, {{Query}} is now in fact already auto-closing, so there is no need for this class.
 In trying to remove it, I realized that this wrapper was being passed around in pretty convoluted
ways and also it was sometimes being created in a {{try-with-resources}} block but then never
actually used in any way.
> Remove the {{QueryWrapper}} from the class and simplify some of the DB interactions.
> https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java#L178



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message