hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22750) Consolidate LockType naming
Date Wed, 08 Apr 2020 20:39:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17078691#comment-17078691
] 

Hive QA commented on HIVE-22750:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 12s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 37s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 57s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 49s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  2m 36s{color} | {color:blue}
standalone-metastore/metastore-common in master has 35 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m  9s{color} | {color:blue}
standalone-metastore/metastore-server in master has 190 extant Findbugs warnings. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 41s{color} | {color:blue}
ql in master has 1528 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 29s{color} | {color:blue}
hcatalog/streaming in master has 11 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 27s{color} | {color:blue}
streaming in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 51s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 29s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 30s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 58s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 58s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 25s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 45 new + 525 unchanged - 44 fixed
= 570 total (was 569) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  9m 38s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 51s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 14s{color} | {color:red}
The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 16s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-21517/dev-support/hive-personality.sh
|
| git revision | master / d2163cb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-21517/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-21517/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore/metastore-common metastore standalone-metastore/metastore-server
ql hcatalog/streaming streaming U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-21517/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Consolidate LockType naming
> ---------------------------
>
>                 Key: HIVE-22750
>                 URL: https://issues.apache.org/jira/browse/HIVE-22750
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Zoltan Chovan
>            Assignee: Marton Bod
>            Priority: Minor
>         Attachments: HIVE-22750.1.patch, HIVE-22750.10.patch, HIVE-22750.11.patch, HIVE-22750.12.patch,
HIVE-22750.2.patch, HIVE-22750.3.patch, HIVE-22750.4.patch, HIVE-22750.5.patch, HIVE-22750.5.patch,
HIVE-22750.6.patch, HIVE-22750.7.patch, HIVE-22750.8.patch, HIVE-22750.9.patch, HIVE-22750.9.patch,
HIVE-22750.9.patch, HIVE-22750.9.patch
>
>
> Extend enum with string literal to remove unnecessary `id` to `char` casting for the
LockType:
> {code:java}
> switch (lockType) {
>             case EXCLUSIVE:
>               lockChar = LOCK_EXCLUSIVE;
>               break;
>             case SHARED_READ:
>               lockChar = LOCK_SHARED;
>               break;
>             case SHARED_WRITE:
>               lockChar = LOCK_SEMI_SHARED;
>               break;
>           }
> {code}
> Consolidate LockType naming in code and schema upgrade scripts:
> {code:java}
> CASE WHEN HL.`HL_LOCK_TYPE` = 'e' THEN 'exclusive' WHEN HL.`HL_LOCK_TYPE` = 'r' THEN
'shared' WHEN HL.`HL_LOCK_TYPE` = 'w' THEN *'semi-shared'* END AS LOCK_TYPE,
> {code}
> +*Lock types:*+
> EXCLUSIVE
>  EXCL_WRITE
>  SHARED_WRITE
>  SHARED_READ



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message