hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22737) Concurrency: FunctionRegistry::getFunctionInfo is static object locked
Date Mon, 27 Apr 2020 06:35:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093059#comment-17093059
] 

Hive QA commented on HIVE-22737:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001261/HIVE-22737.3.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17141 tests executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestJdbcWithServiceDiscovery.testKillQueryWithDifferentServer (batchId=215)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/21962/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21962/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21962/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 13001261 - PreCommit-HIVE-Build

> Concurrency: FunctionRegistry::getFunctionInfo is static object locked
> ----------------------------------------------------------------------
>
>                 Key: HIVE-22737
>                 URL: https://issues.apache.org/jira/browse/HIVE-22737
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, UDF
>            Reporter: Gopal Vijayaraghavan
>            Assignee: Ashutosh Chauhan
>            Priority: Major
>         Attachments: FunctionRegistry-lock.png, HIVE-22737.2.patch, HIVE-22737.3.patch,
HIVE-22737.patch
>
>
> The lock is inside a HS2-wide static object
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java#L191
> {code}
>   // registry for system functions
>   private static final Registry system = new Registry(true);
> {code}
> And this is the lock itself
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java#L332
> {code}
>   public FunctionInfo getFunctionInfo(String functionName) throws SemanticException {
>     lock.lock();
> {code}
>  !FunctionRegistry-lock.png! 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message