hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22990) Build acknowledgement mechanism for repl dump and load
Date Tue, 17 Mar 2020 15:57:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=404822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404822
]

ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Mar/20 15:56
            Start Date: 17/Mar/20 15:56
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on pull request #949: HIVE-22990 Add file based
ack for replication
URL: https://github.com/apache/hive/pull/949#discussion_r393783338
 
 

 ##########
 File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 ##########
 @@ -838,7 +859,26 @@ public void testIncrementalAdds() throws IOException {
     verifySetup("SELECT a from " + dbName + ".ptned_late WHERE b=2", ptn_data_2, driver);
 
     // Perform REPL-DUMP/LOAD
-    incrementalLoadAndVerify(dbName, replDbName);
+    Tuple incrementalDump = incrementalLoadAndVerify(dbName, replDbName);
+    FileSystem fs = new Path(bootstrapDump.dumpLocation).getFileSystem(hconf);
+    boolean dumpAckFound = false;
+    boolean loadAckFound = false;
+    assertFalse(fs.exists(new Path(bootstrapDump.dumpLocation)));
+    fs = new Path(incrementalDump.dumpLocation).getFileSystem(hconf);
+    Path dumpPath = new Path(incrementalDump.dumpLocation, ReplUtils.REPL_HIVE_BASE_DIR);
+    dumpAckFound = false;
+    loadAckFound = false;
+    for (FileStatus status : fs.listStatus(dumpPath)) {
+      if (status.getPath().getName().equalsIgnoreCase(ReplUtils.DUMP_ACKNOWLEDGEMENT)) {
+        dumpAckFound = true;
+      }
+      if (status.getPath().getName().equalsIgnoreCase(ReplUtils.LOAD_ACKNOWLEDGEMENT)) {
+        loadAckFound = true;
+      }
+    }
+
+    assertTrue(dumpAckFound);
+    assertTrue(loadAckFound);
 
 Review comment:
   Why not just use:
   assertTrue(fs.exists(new Path(dumpPath, ReplUtils.DUMP_ACKNOWLEDGEMENT)));
   assertTrue(fs.exists(new Path(dumpPath, ReplUtils.LOAD_ACKNOWLEDGEMENT)));
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 404822)
    Time Spent: 4.5h  (was: 4h 20m)

> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
>                 Key: HIVE-22990
>                 URL: https://issues.apache.org/jira/browse/HIVE-22990
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch, HIVE-22990.03.patch, HIVE-22990.04.patch,
HIVE-22990.05.patch, HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch, HIVE-22990.09.patch,
HIVE-22990.10.patch, HIVE-22990.11.patch, HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
HIVE-22990.15.patch, HIVE-22990.16.patch, HIVE-22990.17.patch, HIVE-22990.18.patch, HIVE-22990.19.patch,
HIVE-22990.20.patch, HIVE-22990.21.patch, HIVE-22990.22.patch, HIVE-22990.patch
>
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message