hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22990) Build acknowledgement mechanism for repl dump and load
Date Mon, 16 Mar 2020 11:38:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=403881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403881
]

ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/20 11:37
            Start Date: 16/Mar/20 11:37
    Worklog Time Spent: 10m 
      Work Description: aasha commented on pull request #949: HIVE-22990 Add file based ack
for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392789944
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadCompleteAckTask.java
 ##########
 @@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.repl;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.ql.ErrorMsg;
+import org.apache.hadoop.hive.ql.exec.Task;
+import org.apache.hadoop.hive.ql.exec.repl.util.ReplUtils;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+import org.apache.hadoop.hive.ql.parse.repl.dump.Utils;
+import org.apache.hadoop.hive.ql.plan.api.StageType;
+
+import java.io.Serializable;
+
+/**
+ * ReplLoadCompleteAckTask.
+ *
+ * Add the load complete acknoledgement.
+ **/
+public class ReplLoadCompleteAckTask extends Task<ReplLoadCompleteAckWork> implements
Serializable {
 
 Review comment:
   If we directly add the ack at the ReplLoadTask complete, its not correct. There can be
DDL Tasks or Copy Tasks which are not yet finished but the Repl Load Task is complete. So
we need to add this task at the end of the DAG so that once all other tasks are complete without
any error only then it writes the ack
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 403881)
    Time Spent: 3.5h  (was: 3h 20m)

> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
>                 Key: HIVE-22990
>                 URL: https://issues.apache.org/jira/browse/HIVE-22990
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch, HIVE-22990.03.patch, HIVE-22990.04.patch,
HIVE-22990.05.patch, HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch, HIVE-22990.09.patch,
HIVE-22990.10.patch, HIVE-22990.11.patch, HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
HIVE-22990.15.patch, HIVE-22990.patch
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message