hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22990) Build acknowledgement mechanism for repl dump and load
Date Mon, 16 Mar 2020 08:21:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22990?focusedWorklogId=403782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403782
]

ASF GitHub Bot logged work on HIVE-22990:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/20 08:20
            Start Date: 16/Mar/20 08:20
    Worklog Time Spent: 10m 
      Work Description: aasha commented on pull request #949: HIVE-22990 Add file based ack
for replication
URL: https://github.com/apache/hive/pull/949#discussion_r392847438
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
 ##########
 @@ -168,6 +185,42 @@ private Long getEventFromPreviousDumpMetadata(Path dumpRoot) throws
IOException,
     return 0L;
   }
 
+  private Path getPreviousDumpMetadataPath(Path dumpRoot) throws IOException {
+    FileSystem fs = dumpRoot.getFileSystem(conf);
+    if (fs.exists(dumpRoot)) {
+      FileStatus[] statuses = fs.listStatus(dumpRoot);
+      if (statuses.length > 0)  {
+        FileStatus latestUpdatedStatus = statuses[0];
+        for (FileStatus status : statuses) {
+          if (status.getModificationTime() > latestUpdatedStatus.getModificationTime())
{
+            latestUpdatedStatus = status;
+          }
+        }
+        return latestUpdatedStatus.getPath();
+      }
+    }
+    return null;
+  }
+
+  private boolean shouldDump(Path previousDumpPath) throws IOException {
+    //If no previous dump means bootstrap. So return true as there was no
+    //previous dump to load
+    if (previousDumpPath == null) {
+      return true;
+    } else {
+      FileSystem fs = previousDumpPath.getFileSystem(conf);
+      if (fs.exists(previousDumpPath)) {
 
 Review comment:
   yes will update that
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 403782)
    Time Spent: 3h 20m  (was: 3h 10m)

> Build acknowledgement mechanism for repl dump and load
> ------------------------------------------------------
>
>                 Key: HIVE-22990
>                 URL: https://issues.apache.org/jira/browse/HIVE-22990
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Aasha Medhi
>            Assignee: Aasha Medhi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22990.01.patch, HIVE-22990.02.patch, HIVE-22990.03.patch, HIVE-22990.04.patch,
HIVE-22990.05.patch, HIVE-22990.06.patch, HIVE-22990.07.patch, HIVE-22990.08.patch, HIVE-22990.09.patch,
HIVE-22990.10.patch, HIVE-22990.11.patch, HIVE-22990.12.patch, HIVE-22990.13.patch, HIVE-22990.14.patch,
HIVE-22990.15.patch, HIVE-22990.patch
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message