hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22940) Make the datasketches functions available as predefined functions
Date Tue, 10 Mar 2020 16:04:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22940?focusedWorklogId=400793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400793
]

ASF GitHub Bot logged work on HIVE-22940:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Mar/20 16:03
            Start Date: 10/Mar/20 16:03
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #930: HIVE-22940 datasketches
functions
URL: https://github.com/apache/hive/pull/930#discussion_r390411646
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/DataSketchesFunctions.java
 ##########
 @@ -0,0 +1,218 @@
+package org.apache.hadoop.hive.ql.exec;
+
+import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFResolver2;
+import org.apache.hadoop.hive.ql.udf.generic.GenericUDTF;
+
+public class DataSketchesFunctions {
+
+  private static final String DATA_TO_SKETCH = "datatosketch";
+  private static final String SKETCH_TO_ESTIMATE_WITH_ERROR_BOUNDS = "sketchToEstimateWithErrorBounds";
+  // FIXME: consider to rename it to simply "estimate" or "evaluate" - in case of the counting
sketches the "sketchto..." doesnt add value
+  private static final String SKETCH_TO_ESTIMATE = "sketchToEstimate";
 
 Review comment:
   I think it might make sense to remove the `get_` prefix - but in that case remove it from
all of the functions...
   what do you think?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 400793)
    Time Spent: 1.5h  (was: 1h 20m)

> Make the datasketches functions available as predefined functions 
> ------------------------------------------------------------------
>
>                 Key: HIVE-22940
>                 URL: https://issues.apache.org/jira/browse/HIVE-22940
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22940.01.patch, HIVE-22940.02.patch
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message