hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22865) Include data in replication staging directory
Date Thu, 05 Mar 2020 14:57:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22865?focusedWorklogId=398410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398410
]

ASF GitHub Bot logged work on HIVE-22865:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Mar/20 14:56
            Start Date: 05/Mar/20 14:56
    Worklog Time Spent: 10m 
      Work Description: aasha commented on pull request #911: HIVE-22865 Include data in replication
staging directory
URL: https://github.com/apache/hive/pull/911#discussion_r388345992
 
 

 ##########
 File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExternalTables.java
 ##########
 @@ -904,8 +901,20 @@ public void replicationWithTableNameContainsKeywords() throws Throwable
{
     return ReplicationTestUtils.externalTableBasePathWithClause(REPLICA_EXTERNAL_BASE, replica);
   }
 
-  private void assertExternalFileInfo(List<String> expected, Path externalTableInfoFile)
+  private void assertExternalFileInfo(List<String> expected, String dumplocation) throws
IOException {
+    assertExternalFileInfo(expected, dumplocation, null);
+  }
+  private void assertExternalFileInfo(List<String> expected, String dumplocation, String
dbName)
       throws IOException {
+    Path externalTableInfoFile = new Path(dumplocation, relativeExtInfoPath(dbName));
     ReplicationTestUtils.assertExternalFileInfo(primary, expected, externalTableInfoFile);
   }
+  private String relativeExtInfoPath(String dbName) {
+
+    if (dbName == null) {
 
 Review comment:
   For incremental dbname is not needed?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 398410)
    Time Spent: 4h 20m  (was: 4h 10m)

> Include data in replication staging directory
> ---------------------------------------------
>
>                 Key: HIVE-22865
>                 URL: https://issues.apache.org/jira/browse/HIVE-22865
>             Project: Hive
>          Issue Type: Task
>            Reporter: PRAVIN KUMAR SINHA
>            Assignee: PRAVIN KUMAR SINHA
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22865.1.patch, HIVE-22865.10.patch, HIVE-22865.11.patch, HIVE-22865.2.patch,
HIVE-22865.3.patch, HIVE-22865.4.patch, HIVE-22865.5.patch, HIVE-22865.6.patch, HIVE-22865.7.patch,
HIVE-22865.8.patch, HIVE-22865.9.patch
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message