From issues-return-179616-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Feb 20 03:48:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 09EB2180674 for ; Thu, 20 Feb 2020 04:48:04 +0100 (CET) Received: (qmail 21599 invoked by uid 500); 20 Feb 2020 03:48:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 21549 invoked by uid 99); 20 Feb 2020 03:48:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2020 03:48:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D374E29D3 for ; Thu, 20 Feb 2020 03:48:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1DCF37803E8 for ; Thu, 20 Feb 2020 03:48:00 +0000 (UTC) Date: Thu, 20 Feb 2020 03:48:00 +0000 (UTC) From: "Hive QA (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-22862) Remove unnecessary calls to isEnoughToCompact MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22862?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1704= 0605#comment-17040605 ]=20 Hive QA commented on HIVE-22862: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12993867/HIVE-22862.04.pat= ch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 18045 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20740/test= Report Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20740/co= nsole Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20740/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12993867 - PreCommit-HIVE-Build > Remove unnecessary calls to isEnoughToCompact > --------------------------------------------- > > Key: HIVE-22862 > URL: https://issues.apache.org/jira/browse/HIVE-22862 > Project: Hive > Issue Type: Improvement > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Minor > Attachments: HIVE-22862.01.patch, HIVE-22862.01.patch, HIVE-22862= .02.patch, HIVE-22862.03.patch, HIVE-22862.04.patch > > > QueryCompactor.Util#isEnoughToCompact is called in Worker#run once before= any sort of compaction is run, after this it is called in 3 other places d= uring compaction unnecessarily.=C2=A0 -- This message was sent by Atlassian Jira (v8.3.4#803005)