From issues-return-180213-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Feb 26 14:56:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1ED2D18065C for ; Wed, 26 Feb 2020 15:56:02 +0100 (CET) Received: (qmail 74935 invoked by uid 500); 26 Feb 2020 14:56:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 74925 invoked by uid 99); 26 Feb 2020 14:56:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2020 14:56:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CCF13E2B85 for ; Wed, 26 Feb 2020 14:56:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 2B5C678019E for ; Wed, 26 Feb 2020 14:56:00 +0000 (UTC) Date: Wed, 26 Feb 2020 14:56:00 +0000 (UTC) From: "David Mollitor (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-22763) 0 is accepted in 12-hour format during timestamp cast MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045601#comment-17045601 ] David Mollitor commented on HIVE-22763: --------------------------------------- Excellent. Thanks. +1 > 0 is accepted in 12-hour format during timestamp cast > ----------------------------------------------------- > > Key: HIVE-22763 > URL: https://issues.apache.org/jira/browse/HIVE-22763 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: Karen Coppage > Assignee: Karen Coppage > Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.01.patch, HIVE-22763.02.patch, HIVE-22763.03.patch, HIVE-22763.04.patch, HIVE-22763.04.patch > > > Having a timestamp string in 12-hour format can be parsed if the hour is 0, however, based on the [design document|https://docs.google.com/document/d/1V7k6-lrPGW7_uhqM-FhKl3QsxwCRy69v2KIxPsGjc1k/edit], it should be rejected. > h3. How to reproduce > Run {code}select cast("2020-01-01 0 am 00" as timestamp format "yyyy-mm-dd hh12 p.m. ss"){code} > It shouldn' t be parsed, as the hour component is 0. > h3. Spec > ||Pattern||Meaning||Additional details|| > |HH12|Hour of day (1-12)|Same as HH| > |HH|Hour of day (1-12)|{panel:borderStyle=none} > - One digit inputs are possible in a string to datetime conversion but needs to be surrounded by separators. > - In a datetime to string conversion one digit hours are prefixed with a zero. > - Error if provided hour is not between 1 and 12. > - Displaying an unformatted timestamp in Impala uses the HH24 format regardless if it was created using HH12. > - If no AM/PM provided then defaults to AM. > - In string to datetime conversion, conflicts with SSSSS and HH24.{panel:borderStyle=none}| -- This message was sent by Atlassian Jira (v8.3.4#803005)