hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22891) Skip PartitonDesc Extraction In CombineHiveRecord For Non-LLAP Execution Mode
Date Sat, 15 Feb 2020 22:32:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037650#comment-17037650
] 

Hive QA commented on HIVE-22891:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 50s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  1s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 44s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 56s{color} | {color:blue}
ql in master has 1534 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 58s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 29s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  4s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  4s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 43s{color} | {color:red}
ql: The patch generated 1 new + 22 unchanged - 1 fixed = 23 total (was 23) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  6s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 33s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20656/dev-support/hive-personality.sh
|
| git revision | master / 052b795 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20656/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20656/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Skip PartitonDesc Extraction In CombineHiveRecord For Non-LLAP Execution Mode
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-22891
>                 URL: https://issues.apache.org/jira/browse/HIVE-22891
>             Project: Hive
>          Issue Type: Task
>            Reporter: Syed Shameerur Rahman
>            Assignee: Syed Shameerur Rahman
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22891.01.patch
>
>
> {code:java}
> try {
>       // TODO: refactor this out
>       if (pathToPartInfo == null) {
>         MapWork mrwork;
>         if (HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_EXECUTION_ENGINE).equals("tez"))
{
>           mrwork = (MapWork) Utilities.getMergeWork(jobConf);
>           if (mrwork == null) {
>             mrwork = Utilities.getMapWork(jobConf);
>           }
>         } else {
>           mrwork = Utilities.getMapWork(jobConf);
>         }
>         pathToPartInfo = mrwork.getPathToPartitionInfo();
>       }      PartitionDesc part = extractSinglePartSpec(hsplit);
>       inputFormat = HiveInputFormat.wrapForLlap(inputFormat, jobConf, part);
>     } catch (HiveException e) {
>       throw new IOException(e);
>     }
> {code}
> The above piece of code in CombineHiveRecordReader.java was introduced in HIVE-15147.
This overwrites inputFormat based on the PartitionDesc which is not required in non-LLAP mode
of execution as the method HiveInputFormat.wrapForLlap() simply returns the previously defined
inputFormat in case of non-LLAP mode. The method call extractSinglePartSpec() has some serious
performance implications. If there are large no. of small files, each call in the method extractSinglePartSpec()
takes approx ~ (2 - 3) seconds. Hence the same query which runs in Hive 1.x / Hive 2 is way
faster than the query run on latest hive.
> {code:java}
> 2020-02-11 07:15:04,701 INFO [main] org.apache.hadoop.hive.ql.io.orc.ReaderImpl: Reading
ORC rows from 
> 2020-02-11 07:15:06,468 WARN [main] org.apache.hadoop.hive.ql.io.CombineHiveRecordReader:
Multiple partitions found; not going to pass a part spec to LLAP IO: {{logdate=2020-02-03,
hour=01, event=win}} and {{logdate=2020-02-03, hour=02, event=act}}
> 2020-02-11 07:15:06,468 INFO [main] org.apache.hadoop.hive.ql.io.CombineHiveRecordReader:
succeeded in getting org.apache.hadoop.mapred.FileSplit{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message