hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shivam (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22771) Partition location incorrectly formed in FileOutputCommitterContainer
Date Tue, 11 Feb 2020 05:33:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034143#comment-17034143
] 

Shivam commented on HIVE-22771:
-------------------------------

[~mithun] [~dvoros] Any comments?.  Do you think this patch is okay to go? or I should try
generating a string hashId?

> Partition location incorrectly formed in FileOutputCommitterContainer
> ---------------------------------------------------------------------
>
>                 Key: HIVE-22771
>                 URL: https://issues.apache.org/jira/browse/HIVE-22771
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>    Affects Versions: 1.2.1
>            Reporter: Shivam
>            Assignee: Shivam
>            Priority: Critical
>              Labels: pull-request-available
>         Attachments: HIVE-22771.2.patch, HIVE-22771.3.patch, HIVE-22771.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Class _HCatOutputFormat_ in package _org.apache.hive.hcatalog.mapreduce_ uses function _setOutput_
to generate _idHash_ using below statement:
> *+In file org/apache/hive/hcatalog/mapreduce/HCatOutputFormat.java+*
>  *line 116: idHash = String.valueOf(Math.random());*
> The output of idHash can be similar to values like this : 7.145347157239135E-4
>  
> And, in class _FileOutputCommitterContainer_ in package _org.apache.hive.hcatalog.mapreduce;_
> Uses below statement to compute final partition path:
> +*In org/apache/hive/hcatalog/mapreduce/FileOutputCommitterContainer.java*+
> *line 366: String finalLocn = jobLocation.replaceAll(Path.SEPARATOR + SCRATCH_DIR_NAME
+ "{color:#ff0000}\\d\\.?
> d+"{color},"");*
> *line 367: partPath = new Path(finalLocn);*
>  
> Regex used here is incorrect, since it will only remove integers after the *SCRATCH_DIR_NAME,* and
hence will append  'E-4' (for the above example) in the final partition location. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message