hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22728) Limit the scope of uniqueness of constraint name to database
Date Tue, 11 Feb 2020 13:06:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034426#comment-17034426
] 

Hive QA commented on HIVE-22728:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 41s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 55s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 44s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 13s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 21s{color} | {color:blue}
standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color}
|
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  0s{color} | {color:blue}
ql in master has 1532 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 28s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 27s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 14s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 44s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 44s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 24s{color} | {color:red}
standalone-metastore/metastore-server: The patch generated 5 new + 724 unchanged - 80 fixed
= 729 total (was 804) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 27s{color} | {color:red}
standalone-metastore/metastore-server generated 4 new + 181 unchanged - 0 fixed = 185 total
(was 181) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 25s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m  2s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:standalone-metastore/metastore-server |
|  |  org.apache.hadoop.hive.metastore.model.MConstraint.dnCopyKeyFieldsFromObjectId(Object)
might ignore java.lang.Exception  In MConstraint.java:In MConstraint.java |
|  |  org.apache.hadoop.hive.metastore.model.MConstraint.dnCopyKeyFieldsFromObjectId(Persistable$ObjectIdFieldConsumer,
Object) might ignore java.lang.Exception  In MConstraint.java: In MConstraint.java |
|  |  org.apache.hadoop.hive.metastore.model.MConstraint.dnCopyKeyFieldsToObjectId(Object)
might ignore java.lang.Exception  In MConstraint.java:In MConstraint.java |
|  |  org.apache.hadoop.hive.metastore.model.MConstraint.dnCopyKeyFieldsToObjectId(Persistable$ObjectIdFieldSupplier,
Object) might ignore java.lang.Exception  In MConstraint.java: In MConstraint.java |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-20556/dev-support/hive-personality.sh
|
| git revision | master / 8ff1fb9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-20556/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-20556/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-20556/yetus/new-findbugs-standalone-metastore_metastore-server.html
|
| modules | C: metastore standalone-metastore/metastore-server ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-20556/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Limit the scope of uniqueness of constraint name to database
> ------------------------------------------------------------
>
>                 Key: HIVE-22728
>                 URL: https://issues.apache.org/jira/browse/HIVE-22728
>             Project: Hive
>          Issue Type: Wish
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Miklos Gergely
>            Priority: Major
>         Attachments: HIVE-22728.01.patch
>
>
> Currently, constraint names are globally unique across all databases (assumption is that
this may have done by design). Nevertheless, though behavior seems to be implementation specific,
it would be interesting to limit the scope to uniqueness per database.
> Currently we do not store database information with the constraints. To change the scope
to one db, we would need to store the DB_ID in the KEY_CONSTRAINTS table in metastore when
we create a constraint and add the DB_ID to the PRIMARY KEY of that table. Some minor changes
to the error messages would be needed too, since otherwise it would be difficult to identify
the correct violation in queries that span across multiple databases. Additionally, the SQL
scripts will need to be updated to populate the DB_ID when we upgrade to new version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message