hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22585) Clean up catalog/db/table name usage
Date Thu, 20 Feb 2020 13:33:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22585?focusedWorklogId=389931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389931
]

ASF GitHub Bot logged work on HIVE-22585:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Feb/20 13:32
            Start Date: 20/Feb/20 13:32
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #876: HIVE-22585: Clean up catalog/db/table
name usage
URL: https://github.com/apache/hive/pull/876#discussion_r381993869
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
 ##########
 @@ -989,7 +990,7 @@ public void accept(NotificationEvent event) {
       QueryResultsCache cache = QueryResultsCache.getInstance();
       if (cache != null) {
         long eventTime = event.getEventTime() * 1000L;
-        cache.notifyTableChanged(dbName, tableName, eventTime);
+        cache.notifyTableChanged(TableName.fromString(tableName, null, dbName), eventTime);
 
 Review comment:
   I wonder if it would make sense to leave out the category for now....it's not really used
- instead of passing null everywhere we could have a separate method for (db,name)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 389931)
    Time Spent: 0.5h  (was: 20m)

> Clean up catalog/db/table name usage
> ------------------------------------
>
>                 Key: HIVE-22585
>                 URL: https://issues.apache.org/jira/browse/HIVE-22585
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: David Lavati
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available, refactor
>         Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is a followup to HIVE-21198 to address some additional improvement ideas for the
TableName object mentioned inĀ [https://github.com/apache/hive/pull/550] and attempt to remove
all the fishy usages of db/tablenames, as a number of places still rely on certain state changes/black
magic.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message