hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22536) Improve return path enabling/disabling
Date Fri, 13 Dec 2019 18:49:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22536?focusedWorklogId=359585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359585
]

ASF GitHub Bot logged work on HIVE-22536:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Dec/19 18:48
            Start Date: 13/Dec/19 18:48
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #866: HIVE-22536 Improve return
path enabling/disabling
URL: https://github.com/apache/hive/pull/866#discussion_r357782071
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
 ##########
 @@ -464,7 +464,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx) throws SemanticExcept
           // 0. Gen Optimized Plan
           RelNode newPlan = logicalPlan();
 
-          if (this.conf.getBoolVar(HiveConf.ConfVars.HIVE_CBO_RETPATH_HIVEOP)) {
+          if (ReturnPathManager.shouldUse()) {
             if (cboCtx.type == PreCboCtx.Type.VIEW && !materializedView) {
 
 Review comment:
   If it is a create view statement, we fail with `Create view is not supported in cbo return
path.`. I would expect that since view creation is not supported in cbo return path, we just
either 1) do not use return path for view creation, or 2) we only fail if we are setting this
to `true`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 359585)
    Time Spent: 1h 50m  (was: 1h 40m)

> Improve return path enabling/disabling
> --------------------------------------
>
>                 Key: HIVE-22536
>                 URL: https://issues.apache.org/jira/browse/HIVE-22536
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22536.01.patch, HIVE-22536.02.patch, HIVE-22536.03.patch
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Instead of having a boolean for hive.cbo.returnpath.hiveop it should be on/off/supported.
In case of "supported" it should be used for a subset of commands which are already verified
to be able to work with return path. This is a temporary solution for the time while we are
developing return path, before making it the only way to handle commands.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message