From issues-return-172581-archive-asf-public=cust-asf.ponee.io@hive.apache.org Thu Nov 21 00:41:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1F2DC1804BB for ; Thu, 21 Nov 2019 01:41:02 +0100 (CET) Received: (qmail 25498 invoked by uid 500); 21 Nov 2019 00:41:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 25488 invoked by uid 99); 21 Nov 2019 00:41:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2019 00:41:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C324BE0E2E for ; Thu, 21 Nov 2019 00:41:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 42890780376 for ; Thu, 21 Nov 2019 00:41:00 +0000 (UTC) Date: Thu, 21 Nov 2019 00:41:00 +0000 (UTC) From: "Jesus Camacho Rodriguez (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-22369) Handle HiveTableFunctionScan at return path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22369?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1697= 8863#comment-16978863 ]=20 Jesus Camacho Rodriguez commented on HIVE-22369: ------------------------------------------------ [~mgergely], I believe latest patch has some unrelated changes. Can we crea= te a new issue and submit a new patch for them?=20 Other than that, +1 > Handle HiveTableFunctionScan at return path > ------------------------------------------- > > Key: HIVE-22369 > URL: https://issues.apache.org/jira/browse/HIVE-22369 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22369.01.patch, HIVE-22369.02.patch > > Time Spent: 1h > Remaining Estimate: 0h > > The [optimizedOptiqPlan|https://github.com/apache/hive/blob/5c91d324f22c2= ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/Cal= citePlanner.java#L1573]=C2=A0at CalcitePlanner.getOptimizedHiveOPDag is ult= imately generated by CalcitePlanner.internalGenSelectLogicalPlan, which may= either provide a [HiveProject|https://github.com/apache/hive/blob/5c91d324= f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/pars= e/CalcitePlanner.java#L4831]=C2=A0or a [HiveTableFunctionScan|https://githu= b.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java= /org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L4776]. When=C2=A0Hive= CalciteUtil.getTopLevelSelect is invoked on this it is looking for a [HiveP= roject|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1= a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalcit= eUtil.java#L633]=C2=A0node in the tree, which if won't find in case of a=C2= =A0HiveTableFunctionScan was returned. This is why=C2=A0TestNewGetSplitsFor= mat is failing with return path. -- This message was sent by Atlassian Jira (v8.3.4#803005)