From issues-return-172492-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Nov 20 09:56:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 11C79180661 for ; Wed, 20 Nov 2019 10:56:01 +0100 (CET) Received: (qmail 33396 invoked by uid 500); 20 Nov 2019 09:56:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 33362 invoked by uid 99); 20 Nov 2019 09:56:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2019 09:56:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B53FEE2E5B for ; Wed, 20 Nov 2019 09:56:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 32A7A7804AA for ; Wed, 20 Nov 2019 09:56:00 +0000 (UTC) Date: Wed, 20 Nov 2019 09:56:00 +0000 (UTC) From: "Karen Coppage (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-21266) Issue with single delta file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21266?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1697= 8277#comment-16978277 ]=20 Karen Coppage commented on HIVE-21266: -------------------------------------- Created a unit test and manually tested the streaming api. In both scenario= s, after compaction and cleaning, the aborted transaction is still marked a= s aborted. There is no issue. I will contribute the unit test to prevent regression. Changing issue name = to: Unit test for potential issue with single delta file > Issue with single delta file > ---------------------------- > > Key: HIVE-21266 > URL: https://issues.apache.org/jira/browse/HIVE-21266 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 4.0.0 > Reporter: Eugene Koifman > Assignee: Karen Coppage > Priority: Major > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop= /hive/ql/txn/compactor/CompactorMR.java#L353-L357] > =C2=A0 > {noformat} > if ((deltaCount + (dir.getBaseDirectory() =3D=3D null ? 0 : 1)) + origCou= nt <=3D 1) { > LOG.debug("Not compacting {}; current base is {} and there are {} d= eltas and {} originals", sd.getLocation(), dir > .getBaseDirectory(), deltaCount, origCount); > return; > } > =C2=A0{noformat} > Is problematic. > Suppose you have 1 delta file from streaming ingest: {{delta_11_20}} wher= e {{txnid:13}} was aborted. The code above will not rewrite the delta (whi= ch drops anything that belongs to the aborted txn) and transition the compa= ction to "ready_for_cleaning" state which will drop the metadata about the = aborted txn in {{markCleaned()}}. Now aborted data will come back as commi= tted. -- This message was sent by Atlassian Jira (v8.3.4#803005)