hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22529) Make Debugging Stacktrace More Explicit
Date Thu, 28 Nov 2019 10:49:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984315#comment-16984315
] 

Hive QA commented on HIVE-22529:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12986978/HIVE-22529.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17751 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19651/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19651/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19651/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12986978 - PreCommit-HIVE-Build

> Make Debugging Stacktrace More Explicit
> ---------------------------------------
>
>                 Key: HIVE-22529
>                 URL: https://issues.apache.org/jira/browse/HIVE-22529
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22529.1.patch, HIVE-22529.1.patch
>
>
> In some places, the following DEBUG logging was introduced:
> {code:java}
> LOG.debug("Message", new Exception());
> {code}
> The purpose of this is to log the stack trace of the Thread calling this debug logging
method.  However, the resulting log message includes the following:
> {code:none}
> 2019-11-19T08:13:31,392 DEBUG [Thread] Logger: Message
> java.lang.Exception: null
>  at ....
> {code}
> To the observer, it appears that there was perhaps some sort of NPE.  Add a message to
the Exception being generated to make it more clear that this "Exception" is for debugging
purposes and not an actual error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message