hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22476) Hive datediff function provided inconsistent results when hive.fetch.task.conversion is set to none
Date Thu, 14 Nov 2019 09:24:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974083#comment-16974083
] 

Hive QA commented on HIVE-22476:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12985778/HIVE-22476.5.patch

{color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17703 tests executed
*Failed tests:*
{noformat}
TestStatsReplicationScenariosACIDNoAutogather - did not produce a TEST-*.xml file (likely
timed out) (batchId=256)
org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFLastDay.testWrongTsStr (batchId=316)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19416/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19416/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19416/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12985778 - PreCommit-HIVE-Build

> Hive datediff function provided inconsistent results when hive.fetch.task.conversion
is set to none
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-22476
>                 URL: https://issues.apache.org/jira/browse/HIVE-22476
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Slim Bouguerra
>            Assignee: Slim Bouguerra
>            Priority: Major
>         Attachments: HIVE-22476.2.patch, HIVE-22476.3.patch, HIVE-22476.5.patch, HIVE-22476.patch
>
>
> The actual issue stems to the different date parser used by various part of the engine.
> Fetch task uses udfdatediff via {code} org.apache.hadoop.hive.ql.udf.generic.GenericUDFToDate{code}
while the vectorized llap execution uses {code}VectorUDFDateDiffScalarCol{code}.
> This fix is meant to be not very intrusive and will add more support to the GenericUDFToDate
by enhancing the parser.
> For the longer term will be better to use one parser for all the operators.
> Thanks [~Rajkumar Singh] for the repro example
> {code} 
> create external table testdatediff(datetimecol string) stored as orc;
> insert into testdatediff values ('2019-09-09T10:45:49+02:00'),('2019-07-24');
> select datetimecol from testdatediff where datediff(cast(current_timestamp as string),
datetimecol)<183;
> set hive.ferch.task.conversion=none;
> select datetimecol from testdatediff where datediff(cast(current_timestamp as string),
datetimecol)<183;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message