hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
Date Tue, 26 Nov 2019 06:16:01 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349588
]

ASF GitHub Bot logged work on HIVE-22463:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Nov/19 06:15
            Start Date: 26/Nov/19 06:15
    Worklog Time Spent: 10m 
      Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463 decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558504
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
 ##########
 @@ -286,19 +292,24 @@ public boolean matches(Descriptor other) {
           return false;
         }
       }
+      if (unscaled != other.unscaled) {
+        return false;
+      }
       return true;
     }
 
     private final Mode mode;
     private final ArgumentType [] argTypes;
     private final InputExpressionType [] exprTypes;
     private final int argCount;
+    private boolean unscaled;
 
 Review comment:
   The build has non-finals, but the actual class has all finals (that's a good convention)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 349588)
    Time Spent: 1h 50m  (was: 1h 40m)

> Support Decimal64 column multiplication with decimal64 Column/Scalar
> --------------------------------------------------------------------
>
>                 Key: HIVE-22463
>                 URL: https://issues.apache.org/jira/browse/HIVE-22463
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ramesh Kumar Thangarajan
>            Assignee: Ramesh Kumar Thangarajan
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, HIVE-22463.11.patch, HIVE-22463.2.patch,
HIVE-22463.3.patch, HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch,
HIVE-22463.9.patch
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message