hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22441) Metrics Subsytem Improvements
Date Fri, 01 Nov 2019 15:21:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964900#comment-16964900
] 

Hive QA commented on HIVE-22441:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12984605/HIVE-22441.2.patch

{color:green}SUCCESS:{color} +1 due to 13 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 17546 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterChange (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDisableEnable (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testFifoSchedulingPolicy (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testMappings (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testMoveSessions (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testMoveSessionsMultiPool (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueName (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool (batchId=344)
org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing (batchId=344)
org.apache.hadoop.hive.ql.hooks.TestMetricsQueryLifeTimeHook.testNoErrorOnDisabledMetrics
(batchId=350)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19249/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19249/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19249/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 19 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12984605 - PreCommit-HIVE-Build

> Metrics Subsytem Improvements
> -----------------------------
>
>                 Key: HIVE-22441
>                 URL: https://issues.apache.org/jira/browse/HIVE-22441
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22441.1.patch, HIVE-22441.2.patch
>
>
> # CodahaleMetrics uses Guava LoadingCache, which is already thread-safe, and then puts
an explicit lock around the structure.  Use Java 8 new Map API with ConcurrentHashMap.
> # Introduce Java 8 APIs
> # Simplifications
> # Updated unit tests to no longer include a 'sleep'
> https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java#L91-L94



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message