hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22414) Make LLAP CacheTags more memory efficient
Date Wed, 06 Nov 2019 22:09:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968759#comment-16968759
] 

Hive QA commented on HIVE-22414:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  1s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  2m  5s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 55s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 37s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 27s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 24s{color} | {color:blue}
storage-api in master has 48 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 47s{color} | {color:blue}
llap-server in master has 90 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 30s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 30s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 24s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m 23s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 23s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 26s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 20s{color} | {color:red}
llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m 10s{color} | {color:red}
storage-api generated 1 new + 28 unchanged - 0 fixed = 29 total (was 28) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m  9s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19320/dev-support/hive-personality.sh
|
| git revision | master / 4cfb7a0 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus/patch-mvninstall-llap-server.txt
|
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus/patch-compile-llap-server.txt
|
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus/patch-compile-llap-server.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus/patch-findbugs-llap-server.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus/diff-javadoc-javadoc-storage-api.txt
|
| modules | C: storage-api llap-server U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19320/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Make LLAP CacheTags more memory efficient
> -----------------------------------------
>
>                 Key: HIVE-22414
>                 URL: https://issues.apache.org/jira/browse/HIVE-22414
>             Project: Hive
>          Issue Type: Improvement
>          Components: llap
>            Reporter: Ádám Szita
>            Assignee: Ádám Szita
>            Priority: Major
>         Attachments: HIVE-22414.0.patch, HIVE-22414.1.patch, HIVE-22414.2.patch, HIVE-22414.3.patch,
HIVE-22414.4.patch, HIVE-22414.5.patch, HIVE-22414.6.patch
>
>
> MultiPartitionCacheTag relies on LinkedLists.
> A LinkedList object that holds e.g. 2 nodes consumes 112 bytes roughly in this composition:
>  * 16 bytes for LinkedList object header
>  * 8 bytes for referring head
>  * 8 bytes for referring tail
>  * 80 = 2 x (16 bytes for LinkedList$Node header, 3 x 8 bytes for referring prev, next,
item)
> This is a lot, so I propose to replace LinkedList in MultiPartitionCacheTag with a simple
String array. (For a similar scenario an array would take 16 + 8 + 2 x 8 = 40 bytes, as per
header, count, and 2 references for our actual objects).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message