hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22369) Handle HiveTableFunctionScan at return path
Date Tue, 19 Nov 2019 17:04:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22369?focusedWorklogId=346094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346094
]

ASF GitHub Bot logged work on HIVE-22369:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Nov/19 17:03
            Start Date: 19/Nov/19 17:03
    Worklog Time Spent: 10m 
      Work Description: miklosgergely commented on issue #845: HIVE-22369 Handle HiveTableFunctionScan
at return path
URL: https://github.com/apache/hive/pull/845#issuecomment-555606077
 
 
   Added unit tests for the modifications.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 346094)
    Time Spent: 50m  (was: 40m)

> Handle HiveTableFunctionScan at return path
> -------------------------------------------
>
>                 Key: HIVE-22369
>                 URL: https://issues.apache.org/jira/browse/HIVE-22369
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22369.01.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The [optimizedOptiqPlan|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L1573] at
CalcitePlanner.getOptimizedHiveOPDag is ultimately generated by CalcitePlanner.internalGenSelectLogicalPlan,
which may either provide a [HiveProject|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L4831] or
a [HiveTableFunctionScan|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java#L4776].
When HiveCalciteUtil.getTopLevelSelect is invoked on this it is looking for a [HiveProject|https://github.com/apache/hive/blob/5c91d324f22c2ae47e234e76a9bc5ee1a71e6a70/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java#L633] node
in the tree, which if won't find in case of a HiveTableFunctionScan was returned. This is
why TestNewGetSplitsFormat is failing with return path.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message