hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22329) Create DriverContext
Date Sat, 16 Nov 2019 09:41:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16975651#comment-16975651
] 

Hive QA commented on HIVE-22329:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 49s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 34s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 14s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 23s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 12s{color} | {color:blue}
ql in master has 1544 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
hcatalog/core in master has 36 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 43s{color} | {color:blue}
itests/hive-unit in master has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 45s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 28s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 37s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 19s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 19s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 45s{color} | {color:red}
ql: The patch generated 10 new + 346 unchanged - 72 fixed = 356 total (was 418) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 15s{color} | {color:red}
ql generated 13 new + 1531 unchanged - 13 fixed = 1544 total (was 1544) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  3s{color} | {color:red}
ql generated 1 new + 99 unchanged - 1 fixed = 100 total (was 100) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 36m 15s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Naked notify in org.apache.hadoop.hive.ql.TaskQueue.releaseRunnable()  At TaskQueue.java:At
TaskQueue.java:[line 98] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute():in
org.apache.hadoop.hive.ql.exec.ExplainSQRewriteTask.execute(): new java.io.PrintStream(OutputStream)
 At ExplainSQRewriteTask.java:[line 59] |
|  |  Dead store to jsonPlan in org.apache.hadoop.hive.ql.exec.ExplainTask.execute()  At ExplainTask.java:org.apache.hadoop.hive.ql.exec.ExplainTask.execute()
 At ExplainTask.java:[line 454] |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.ExplainTask.execute():in
org.apache.hadoop.hive.ql.exec.ExplainTask.execute(): new java.io.PrintStream(OutputStream)
 At ExplainTask.java:[line 406] |
|  |  Invocation of toString on org.apache.hadoop.hive.ql.plan.CopyWork.getFromPaths() in
org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute()  At ReplCopyTask.java:in org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute()
 At ReplCopyTask.java:[line 145] |
|  |  Invocation of toString on org.apache.hadoop.hive.ql.plan.CopyWork.getToPaths() in org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute()
 At ReplCopyTask.java:in org.apache.hadoop.hive.ql.exec.ReplCopyTask.execute()  At ReplCopyTask.java:[line
145] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute()
 At MapRedTask.java:is not thrown in org.apache.hadoop.hive.ql.exec.mr.MapRedTask.execute()
 At MapRedTask.java:[line 319] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInChildVM()
 At MapredLocalTask.java:is not thrown in org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInChildVM()
 At MapredLocalTask.java:[line 360] |
|  |  Write to static field org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.memoryMXBean
from instance method org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInProcess()
 At MapredLocalTask.java:from instance method org.apache.hadoop.hive.ql.exec.mr.MapredLocalTask.executeInProcess()
 At MapredLocalTask.java:[line 380] |
|  |  Write to static field org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.numIteration
from instance method org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.build(Context,
Hive, Logger, TaskTracker)  At IncrementalLoadTasksBuilder.java:from instance method org.apache.hadoop.hive.ql.exec.repl.incremental.IncrementalLoadTasksBuilder.build(Context,
Hive, Logger, TaskTracker)  At IncrementalLoadTasksBuilder.java:[line 97] |
|  |  org.apache.hadoop.hive.ql.exec.spark.LocalHiveSparkClient.execute(TaskQueue, Context,
SparkWork) makes inefficient use of keySet iterator instead of entrySet iterator  At LocalHiveSparkClient.java:use
of keySet iterator instead of entrySet iterator  At LocalHiveSparkClient.java:[line 147] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.exec.spark.SparkTask.execute()
 At SparkTask.java:is not thrown in org.apache.hadoop.hive.ql.exec.spark.SparkTask.execute()
 At SparkTask.java:[line 194] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.io.merge.MergeFileTask.execute()
 At MergeFileTask.java:is not thrown in org.apache.hadoop.hive.ql.io.merge.MergeFileTask.execute()
 At MergeFileTask.java:[line 160] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19455/dev-support/hive-personality.sh
|
| git revision | master / af0f325 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19455/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-19455/yetus/new-findbugs-ql.html
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-19455/yetus/diff-javadoc-javadoc-ql.txt
|
| modules | C: ql hcatalog/core itests/hive-unit U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19455/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Create DriverContext
> --------------------
>
>                 Key: HIVE-22329
>                 URL: https://issues.apache.org/jira/browse/HIVE-22329
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22329.01.patch, HIVE-22329.02.patch, HIVE-22329.03.patch, HIVE-22329.04.patch
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The current DriverContext class is not really a context, rather a queue, thus it should
be renamed to DriverQueue. At the same time Driver has a a lot of fields, they should be in
a real context class called DriverContext, which would also facilitate the extraction of independent
parts of the Driver class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message