hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22274) Upgrade Calcite version to 1.21.0
Date Wed, 09 Oct 2019 19:45:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947951#comment-16947951
] 

Hive QA commented on HIVE-22274:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 42s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 34s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 32s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 44s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  2s{color} | {color:blue}
ql in master has 1550 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  8m 10s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m  1s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  7m 39s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  7m 39s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 43s{color} | {color:red}
ql: The patch generated 31 new + 369 unchanged - 11 fixed = 400 total (was 380) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  2m  0s{color} | {color:red}
root: The patch generated 31 new + 369 unchanged - 11 fixed = 400 total (was 380) {color}
|
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  1s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 18s{color} | {color:red}
ql generated 7 new + 1548 unchanged - 2 fixed = 1555 total (was 1550) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  1s{color} | {color:red}
ql generated 4 new + 96 unchanged - 4 fixed = 100 total (was 100) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  6m 44s{color} | {color:red}
root generated 4 new + 333 unchanged - 4 fixed = 337 total (was 337) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 14s{color} | {color:red}
The patch generated 3 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 44s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to joinInfo in org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean)  At HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveJoinFactoryImpl.createJoin(RelNode,
RelNode, RexNode, Set, JoinRelType, boolean)  At HiveRelFactories.java:[line 166] |
|  |  Dead store to joinInfo in org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode,
RelNode, RexNode)  At HiveRelFactories.java:org.apache.hadoop.hive.ql.optimizer.calcite.HiveRelFactories$HiveSemiJoinFactoryImpl.createSemiJoin(RelNode,
RelNode, RexNode)  At HiveRelFactories.java:[line 183] |
|  |  Dead store to rightKeys in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
 At HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
 At HiveRelDecorrelator.java:[line 1465] |
|  |  Dead store to leftKeys in org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
 At HiveRelDecorrelator.java:org.apache.hadoop.hive.ql.optimizer.calcite.rules.HiveRelDecorrelator.decorrelateRel(LogicalCorrelate)
 At HiveRelDecorrelator.java:[line 1464] |
|  |  instanceof will always return true for all non-null values in new org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdPredicates$JoinConditionBasedPredicateInference(Join,
RexNode, RexNode), since all org.apache.calcite.rel.core.Join are instances of org.apache.calcite.rel.core.Join
 At HiveRelMdPredicates.java:for all non-null values in new org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdPredicates$JoinConditionBasedPredicateInference(Join,
RexNode, RexNode), since all org.apache.calcite.rel.core.Join are instances of org.apache.calcite.rel.core.Join
 At HiveRelMdPredicates.java:[line 318] |
|  |  Redundant nullcheck of lefts, which is known to be non-null in org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin,
RelMetadataQuery)  Redundant null check at HiveRelMdSize.java:is known to be non-null in org.apache.hadoop.hive.ql.optimizer.calcite.stats.HiveRelMdSize.averageColumnSizes(HiveSemiJoin,
RelMetadataQuery)  Redundant null check at HiveRelMdSize.java:[line 90] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.optimizer.calcite.translator.ASTBuilder.join(ASTNode,
ASTNode, JoinRelType, ASTNode, boolean) where default case is missing  At ASTBuilder.java:ASTNode,
JoinRelType, ASTNode, boolean) where default case is missing  At ASTBuilder.java:[lines 163-179]
|
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  xml  compile  findbugs  checkstyle  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18924/dev-support/hive-personality.sh
|
| git revision | master / c104e8b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/diff-checkstyle-ql.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/diff-checkstyle-root.txt
|
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/whitespace-eol.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/new-findbugs-ql.html
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/diff-javadoc-javadoc-ql.txt
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/diff-javadoc-javadoc-root.txt
|
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus/patch-asflicense-problems.txt
|
| modules | C: ql . U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18924/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Upgrade Calcite version to 1.21.0
> ---------------------------------
>
>                 Key: HIVE-22274
>                 URL: https://issues.apache.org/jira/browse/HIVE-22274
>             Project: Hive
>          Issue Type: Task
>    Affects Versions: 3.1.2
>            Reporter: Steve Carlin
>            Assignee: Steve Carlin
>            Priority: Major
>         Attachments: HIVE-22274.1.patch, HIVE-22274.2.patch, HIVE-22274.3.patch, HIVE-22274.4.patch,
HIVE-22274.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message