hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22269) Stats miss with "hive.optimize.sort.dynamic.partition" (SortedDynPartitionOptimizer) leads to wrong reducer count
Date Tue, 01 Oct 2019 00:55:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941429#comment-16941429
] 

Hive QA commented on HIVE-22269:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  3m 53s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 59s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 40s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 54s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 20s{color} | {color:blue}
ql in master has 1552 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 16s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 25s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 56s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 31s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 31s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 50s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 11s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 16s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 30m 58s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18799/dev-support/hive-personality.sh
|
| git revision | master / e06bf8d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql itests/hive-blobstore U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18799/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Stats miss with "hive.optimize.sort.dynamic.partition" (SortedDynPartitionOptimizer)
leads to wrong reducer count
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-22269
>                 URL: https://issues.apache.org/jira/browse/HIVE-22269
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-22269.1.patch, HIVE-22269.2.patch
>
>
> {{hive.optimize.sort.dynamic.partition=true}} introduces new stage to reduce number of
writes in dynamic partitioning usecase. Earlier {{SortedDynPartitionOptimizer}} added this
new operator via {{Optimizer.java}} and the stats for the newly added operator was populated
via {{StatsRulesProcFactory$ReduceSinkStatsRule}}.
> However, with "HIVE-20703" this got changed. This is moved to {{TezCompiler}} for cost
based decision. Though the operator gets added correctly, the stats for this does not get
added (as it runs after runStatsAnnotation()).
> This causes reducer count to be mis-estimated in the query.
> {noformat}
> e.g For the following query, reducer_2 would be estimated as "2" instead of "1009". This
causes huge delay in the runtime.
> explain 
> from tpcds_xtext_1000.store_sales ss
> insert overwrite table store_sales partition (ss_sold_date_sk)
> select
>         ss.ss_sold_time_sk,
>         ss.ss_item_sk,
>         ss.ss_customer_sk,
>         ss.ss_cdemo_sk,
>         ss.ss_hdemo_sk,
>         ss.ss_addr_sk,
>         ss.ss_store_sk,
>         ss.ss_promo_sk,
>         ss.ss_ticket_number,
>         ss.ss_quantity,
>         ss.ss_wholesale_cost,
>         ss.ss_list_price,
>         ss.ss_sales_price,
>         ss.ss_ext_discount_amt,
>         ss.ss_ext_sales_price,
>         ss.ss_ext_wholesale_cost,
>         ss.ss_ext_list_price,
>         ss.ss_ext_tax,
>         ss.ss_coupon_amt,
>         ss.ss_net_paid,
>         ss.ss_net_paid_inc_tax,
>         ss.ss_net_profit,
>         ss.ss_sold_date_sk
>         where ss.ss_sold_date_sk is not null
> insert overwrite table store_sales partition (ss_sold_date_sk)
> select
>         ss.ss_sold_time_sk,
>         ss.ss_item_sk,
>         ss.ss_customer_sk,
>         ss.ss_cdemo_sk,
>         ss.ss_hdemo_sk,
>         ss.ss_addr_sk,
>         ss.ss_store_sk,
>         ss.ss_promo_sk,
>         ss.ss_ticket_number,
>         ss.ss_quantity,
>         ss.ss_wholesale_cost,
>         ss.ss_list_price,
>         ss.ss_sales_price,
>         ss.ss_ext_discount_amt,
>         ss.ss_ext_sales_price,
>         ss.ss_ext_wholesale_cost,
>         ss.ss_ext_list_price,
>         ss.ss_ext_tax,
>         ss.ss_coupon_amt,
>         ss.ss_net_paid,
>         ss.ss_net_paid_inc_tax,
>         ss.ss_net_profit,
>         ss.ss_sold_date_sk
>         where ss.ss_sold_date_sk is null
>         distribute by ss.ss_item_sk
> ;
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message