From issues-return-166099-archive-asf-public=cust-asf.ponee.io@hive.apache.org Sun Sep 8 10:38:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0F06718062C for ; Sun, 8 Sep 2019 12:38:02 +0200 (CEST) Received: (qmail 53344 invoked by uid 500); 8 Sep 2019 10:38:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 53328 invoked by uid 99); 8 Sep 2019 10:38:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Sep 2019 10:38:04 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1FD7BE30ED for ; Sun, 8 Sep 2019 10:38:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 4A8D6781F24 for ; Sun, 8 Sep 2019 10:38:00 +0000 (UTC) Date: Sun, 8 Sep 2019 10:38:00 +0000 (UTC) From: "ASF GitHub Bot (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-22179) Break up DDLSemanticAnalyzer - extract Function related analyzers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22179?focusedWorklogId=3D= 308479&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpa= nel#worklog-308479 ] ASF GitHub Bot logged work on HIVE-22179: ----------------------------------------- Author: ASF GitHub Bot Created on: 08/Sep/19 10:37 Start Date: 08/Sep/19 10:37 Worklog Time Spent: 10m=20 Work Description: miklosgergely commented on pull request #763: HIVE-= 22179 Break up DDLSemanticAnalyzer - extract Function related analyzers URL: https://github.com/apache/hive/pull/763 =20 =20 DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal= is to refactor it in order to have everything cut into more handleable cla= sses under the package org.apache.hadoop.hive.ql.exec.ddl: =20 - have a separate class for each analyzers - have a package for each operation, containing an analyzer, a descripti= on, and an operation, so the amount of classes under a package is more mana= geable =20 Step #2: extract all the functin related analyzers from DDLSemanticAnaly= zer and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them u= nder the new package. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 308479) Remaining Estimate: 0h Time Spent: 10m > Break up DDLSemanticAnalyzer - extract Function related analyzers > ----------------------------------------------------------------- > > Key: HIVE-22179 > URL: https://issues.apache.org/jira/browse/HIVE-22179 > Project: Hive > Issue Type: Sub-task > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Labels: pull-request-available, refactor-ddl > Attachments: HIVE-22179.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal = is to refactor it in order to have everything cut into more handleable clas= ses under the package=C2=A0 org.apache.hadoop.hive.ql.exec.ddl: > * have a separate class for each analyzers > * have a package for each operation, containing an analyzer, a descripti= on, and an operation, so the amount of classes under a package is more mana= geable > Step #2: extract all the functin related analyzers from DDLSemanticAnalyz= er and FunctionSemanticAnalyzer and MacroSemanticAnalyzer, and move them un= der the new package. -- This message was sent by Atlassian Jira (v8.3.2#803003)