hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (HIVE-22209) Creating a materialized view with no tables should be handled more gracefully
Date Tue, 24 Sep 2019 17:53:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22209?focusedWorklogId=317722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317722
]

ASF GitHub Bot logged work on HIVE-22209:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Sep/19 17:52
            Start Date: 24/Sep/19 17:52
    Worklog Time Spent: 10m 
      Work Description: jcamachor commented on pull request #782: HIVE-22209: Graceful error
msg when there is no table for a materiali…
URL: https://github.com/apache/hive/pull/782#discussion_r327752325
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java
 ##########
 @@ -456,4 +456,22 @@ public boolean containsQueryWithoutSourceTable() {
     }
     return aliasToTabs.size()==0 && aliasToSubq.size()==0;
   }
+
+  // returns false when the query block doesn't have
+  // a table defined, e.g. "select 5"
+  public boolean hasTableDefined() {
+    // A table is not defined when there only exists a dummy
+    // table in the alias, so if it is blank, we know a table
+    // is defined.
+    if (aliasToTabs.size() == 0) {
 
 Review comment:
   Can we check when you were getting `null`? It is suspicious... AFAIK, before calling this
method, we iterate through the same structure in L14102 in SemanticAnalyzer and alias should
not be null (btw, this code could be integrated within this loop to avoid looping twice).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 317722)
    Time Spent: 1h 20m  (was: 1h 10m)

> Creating a materialized view with no tables should be handled more gracefully
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-22209
>                 URL: https://issues.apache.org/jira/browse/HIVE-22209
>             Project: Hive
>          Issue Type: Bug
>          Components: Materialized views
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Steve Carlin
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HIVE-22209.1.patch, HIVE-22209.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently, materialized views without a table reference are not supported. However, instead
of printing a clear message about it, when a materialized view is created without a table
reference, we fail with an unclear message.
> {code}
> > create materialized view mv_test1 as select 5;
> (...)
> ERROR : FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask.
MetaException(message:Add request failed :
> INSERT INTO MV_TABLES_USED (MV_CREATION_METADATA_ID,TBL_ID) VALUES (?,?) )
> INFO : Completed executing command(queryId=hive_20190916203511_b609cccf-f5e3-45dd-abfd-6e869d94e39a);
Time taken: 10.469 seconds
> Error: Error while processing statement: FAILED: Execution Error, return code 1 from
org.apache.hadoop.hive.ql.exec.DDLTask. MetaExcep
> tion(message:Add request failed : INSERT INTO MV_TABLES_USED (MV_CREATION_METADATA_ID,TBL_ID)
VALUES (?,?) ) (state=08S01,code=1)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message