hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hankó Gergely (Jira) <j...@apache.org>
Subject [jira] [Updated] (HIVE-22202) Remove unnecessary code from ObjectStore.java
Date Tue, 17 Sep 2019 08:02:00 GMT

     [ https://issues.apache.org/jira/browse/HIVE-22202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hankó Gergely updated HIVE-22202:
---------------------------------
    Status: Patch Available  (was: In Progress)

> Remove unnecessary code from ObjectStore.java
> ---------------------------------------------
>
>                 Key: HIVE-22202
>                 URL: https://issues.apache.org/jira/browse/HIVE-22202
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Hankó Gergely
>            Assignee: Hankó Gergely
>            Priority: Minor
>         Attachments: HIVE-22202.1.patch, HIVE-22202.2.patch, HIVE-22202.3.patch
>
>
> Remove unnecessary code
>  * remove unnecessary/unused variables
>  * remove unused private methods
>  * remove unnecessary throws declarations
>  * remove unnecessary conditionals that are guaranteed to always give the same result
>  * simplify collection handling
>  ** use member sort() instead of Collections.sort()
>  ** use addAll() instead of adding one-by-one in a loop
>  * remove Javadoc that doesn't give additional information
>  * use try with resource where possible
>  * remove unnecessary explicit type arguments
>  * remove redundant warning suppression



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message