hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laszlo Bodor (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22191) Simplify SemanticAnalyzer by removing unused code
Date Fri, 27 Sep 2019 08:57:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16939228#comment-16939228
] 

Laszlo Bodor commented on HIVE-22191:
-------------------------------------

+1

> Simplify SemanticAnalyzer by removing unused code
> -------------------------------------------------
>
>                 Key: HIVE-22191
>                 URL: https://issues.apache.org/jira/browse/HIVE-22191
>             Project: Hive
>          Issue Type: Task
>          Components: Hive
>            Reporter: Akos Dombi
>            Assignee: Akos Dombi
>            Priority: Major
>         Attachments: HIVE-22191.2.patch, HIVE-22191.3.patch, HIVE-22191.4.patch, HIVE-22191.5.patch,
HIVE-22191.5.patch, HIVE-22191.patch
>
>
> Simplify {{SemanticAnalyzer}} by:
>  - Remove dead code
>  - Simplify returning statements
>  - Use interfaces types for parameters/fields/variables where it is straightforward to
migrate
>  - Make visibility stricter where it is possible
>  - Check logging to use parametrised logging
>  - Removing unnecessary keywords (e.g.: {{static}})
>  - Some code part could be simplified by using Java 8 features
> I think this is crucial step as this class already contains 15000+ lines of code which
is screaming for splitting into more reasonable classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message