From issues-return-165458-archive-asf-public=cust-asf.ponee.io@hive.apache.org Fri Aug 23 19:23:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D12EA180637 for ; Fri, 23 Aug 2019 21:23:01 +0200 (CEST) Received: (qmail 99985 invoked by uid 500); 23 Aug 2019 19:23:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 99976 invoked by uid 99); 23 Aug 2019 19:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Aug 2019 19:23:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9FE22E2FE5 for ; Fri, 23 Aug 2019 19:23:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0AA65780944 for ; Fri, 23 Aug 2019 19:23:00 +0000 (UTC) Date: Fri, 23 Aug 2019 19:23:00 +0000 (UTC) From: "Laszlo Bodor (Jira)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-22140) Metrics: unify codahale metric frequency unit between metastore and hiveserver2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-22140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-22140: -------------------------------- Summary: Metrics: unify codahale metric frequency unit between metastore and hiveserver2 (was: Metrics: unify codehale metric frequency unit between metastore and hiveserver2) > Metrics: unify codahale metric frequency unit between metastore and hiveserver2 > ------------------------------------------------------------------------------- > > Key: HIVE-22140 > URL: https://issues.apache.org/jira/browse/HIVE-22140 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Laszlo Bodor > Assignee: Laszlo Bodor > Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22140.01.patch, HIVE-22140.01.patch > > > Currently, different default value and even different unit are used for json metric file generation frequency (for metastore and hiveserver2), which is confusing, especially in a situation when a metastore config can fall back to a corresponding hive config (metastore.metrics.file.frequency -> hive.service.metrics.file.frequency). > I think ms would be appropriate for both of them, without even changing the default 1minute for metastore (so changing it to 60000ms is my proposal) > hive.service.metrics.file.frequency > Hiveserver2: > https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > {code:java} > HIVE_METRICS_JSON_FILE_INTERVAL("hive.service.metrics.file.frequency", "5000ms", > new TimeValidator(TimeUnit.MILLISECONDS), > "For metric class org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, " + > "the frequency of updating JSON metrics file."), > {code} > Metastore: > https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > {code:java} > METRICS_JSON_FILE_INTERVAL("metastore.metrics.file.frequency", > "hive.service.metrics.file.frequency", 1, TimeUnit.MINUTES, > "For json metric reporter, the frequency of updating JSON metrics file."), > {code} -- This message was sent by Atlassian Jira (v8.3.2#803003)