hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-22143) Break up DDLSemanticAnalyzer - extract Database related analyzers
Date Thu, 29 Aug 2019 11:45:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-22143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918529#comment-16918529
] 

Hive QA commented on HIVE-22143:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12978824/HIVE-22143.04.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18417/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18417/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18417/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12978824/HIVE-22143.04.patch
was found in seen patch url's cache and a test was probably run already on it. Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12978824 - PreCommit-HIVE-Build

> Break up DDLSemanticAnalyzer - extract Database related analyzers
> -----------------------------------------------------------------
>
>                 Key: HIVE-22143
>                 URL: https://issues.apache.org/jira/browse/HIVE-22143
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-ddl
>         Attachments: HIVE-22143.01.patch, HIVE-22143.02.patch, HIVE-22143.04.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> DDLSemanticAnalyzer is a huge class, more than 4000 lines long. The goal is to refactor
it in order to have everything cut into more handleable classes under the packageĀ  org.apache.hadoop.hive.ql.exec.ddl:
>  * have a separate class for each analyzers
>  * have a package for each operation, containing an analyzer, a description, and an operation,
so the amount of classes under a package is more manageable
> Step #1: extract all the database related analyzers from DDLSemanticAnalyzer, and move
them under the new package. Also create the new internal framework.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message