hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21198) Introduce a database object reference class
Date Fri, 02 Aug 2019 21:30:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899212#comment-16899212
] 

Hive QA commented on HIVE-21198:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 19s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 24s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m  1s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 10s{color}
| {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 25s{color} | {color:blue}
storage-api in master has 48 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 13s{color} | {color:blue}
ql in master has 2250 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 30s{color} | {color:blue}
accumulo-handler in master has 21 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 30s{color} | {color:blue}
beeline in master has 44 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 40s{color} | {color:blue}
hcatalog/core in master has 29 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 29s{color} | {color:blue}
hcatalog/webhcat/java-client in master has 3 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 16s{color} |
{color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 27s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 19s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 58s{color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 11s{color} | {color:red}
storage-api generated 2 new + 0 unchanged - 2 fixed = 2 total (was 2) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} storage-api: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was
5) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 10s{color}
| {color:green} The patch metastore passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 56s{color} | {color:red}
ql: The patch generated 23 new + 1782 unchanged - 64 fixed = 1805 total (was 1846) {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch accumulo-handler passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 12s{color}
| {color:green} The patch beeline passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 14s{color}
| {color:green} The patch core passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color}
| {color:green} The patch java-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 21s{color} | {color:red}
ql generated 4 new + 2248 unchanged - 2 fixed = 2252 total (was 2250) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  1m  2s{color} | {color:red}
ql generated 1 new + 99 unchanged - 1 fixed = 100 total (was 100) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 16s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m  5s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Dead store to table in org.apache.hadoop.hive.ql.ddl.table.misc.AlterTableRenameOperation.doAlteration(Table,
Partition)  At AlterTableRenameOperation.java:org.apache.hadoop.hive.ql.ddl.table.misc.AlterTableRenameOperation.doAlteration(Table,
Partition)  At AlterTableRenameOperation.java:[line 51] |
|  |  Dead store to dbTable in org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTableProps(TableName,
Map, ASTNode, boolean, boolean)  At DDLSemanticAnalyzer.java:org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTableProps(TableName,
Map, ASTNode, boolean, boolean)  At DDLSemanticAnalyzer.java:[line 1793] |
|  |  Exception is caught when Exception is not thrown in org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTablePartMergeFiles(ASTNode,
TableName, HashMap)  At DDLSemanticAnalyzer.java:is not thrown in org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTablePartMergeFiles(ASTNode,
TableName, HashMap)  At DDLSemanticAnalyzer.java:[line 2174] |
|  |  Switch statement found in org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer.analyzeAlterTableCompact(ASTNode,
TableName, HashMap) where default case is missing  At DDLSemanticAnalyzer.java:TableName,
HashMap) where default case is missing  At DDLSemanticAnalyzer.java:[lines 2238-2243] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19)
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18244/dev-support/hive-personality.sh
|
| git revision | master / d7475aa |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-18244/yetus/diff-compile-javac-storage-api.txt
|
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-18244/yetus/diff-checkstyle-ql.txt
|
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-18244/yetus/new-findbugs-ql.html
|
| javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-18244/yetus/diff-javadoc-javadoc-ql.txt
|
| modules | C: storage-api metastore ql accumulo-handler beeline hcatalog/core hcatalog/webhcat/java-client
U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18244/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Introduce a database object reference class
> -------------------------------------------
>
>                 Key: HIVE-21198
>                 URL: https://issues.apache.org/jira/browse/HIVE-21198
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: David Lavati
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-21198.1.patch, HIVE-21198.2.patch, HIVE-21198.3.patch, HIVE-21198.4.patch,
HIVE-21198.5.patch, HIVE-21198.6.patch, HIVE-21198.7.patch, HIVE-21198.8.patch
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> There are many places in which "{databasename}.{tablename}" is passed as a single string;
there are some places where the they travel as 2 separate arguments.
> Idea would be to introduce a simple immutable class with 2 fields ; and pass these informations
together. Making this better is required if we would be wanting to enable dot in tablenames

> HIVE-16907, HIVE-21151



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message