From issues-return-161911-archive-asf-public=cust-asf.ponee.io@hive.apache.org Tue Jul 2 09:11:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 23BF818060E for ; Tue, 2 Jul 2019 11:11:02 +0200 (CEST) Received: (qmail 64892 invoked by uid 500); 2 Jul 2019 09:11:01 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 64872 invoked by uid 99); 2 Jul 2019 09:11:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jul 2019 09:11:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BC2F4E2E67 for ; Tue, 2 Jul 2019 09:11:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 792D826192 for ; Tue, 2 Jul 2019 09:11:00 +0000 (UTC) Date: Tue, 2 Jul 2019 09:11:00 +0000 (UTC) From: "Laszlo Bodor (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-21942) Remove useless MetastoreType enum from AbstractCliConfig MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Bodor updated HIVE-21942: -------------------------------- Description: I'm not 100% aware of historical reasons, but this single-value enum seems totally useless at the moment. https://github.com/apache/hive/blob/86a15600ae610e1c6017019883ef9344585572ef/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java#L50-L52 According to HIVE-14854, it may have made sense when there was an initiative of hbase metastore, but it's not in the scope anymore AFAIK. https://github.com/apache/hive/commit/474425aa62e3f25b119419439373aa684c6c2121 was: I'm not 100% aware of historical reasons, but this single-value enum seems totally useless at the moment. https://github.com/apache/hive/blob/86a15600ae610e1c6017019883ef9344585572ef/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java#L50-L52 According to HIVE-14854, it may have made sense when there was an initiative of hbase metastore, but it's not in the scope anymore AFAIK. > Remove useless MetastoreType enum from AbstractCliConfig > -------------------------------------------------------- > > Key: HIVE-21942 > URL: https://issues.apache.org/jira/browse/HIVE-21942 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure > Reporter: Laszlo Bodor > Priority: Major > Labels: newbie > Fix For: 4.0.0 > > > I'm not 100% aware of historical reasons, but this single-value enum seems totally useless at the moment. > https://github.com/apache/hive/blob/86a15600ae610e1c6017019883ef9344585572ef/itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java#L50-L52 > According to HIVE-14854, it may have made sense when there was an initiative of hbase metastore, but it's not in the scope anymore AFAIK. > https://github.com/apache/hive/commit/474425aa62e3f25b119419439373aa684c6c2121 -- This message was sent by Atlassian JIRA (v7.6.3#76005)