From issues-return-162072-archive-asf-public=cust-asf.ponee.io@hive.apache.org Wed Jul 3 14:59:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C83C21801A7 for ; Wed, 3 Jul 2019 16:59:03 +0200 (CEST) Received: (qmail 15267 invoked by uid 500); 3 Jul 2019 14:59:03 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 15255 invoked by uid 99); 3 Jul 2019 14:59:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2019 14:59:03 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 04B22E2E92 for ; Wed, 3 Jul 2019 14:59:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 580DD26285 for ; Wed, 3 Jul 2019 14:59:01 +0000 (UTC) Date: Wed, 3 Jul 2019 14:59:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (HIVE-21909) Publish the LLAP Daemon capacity through ZooKeeper and honor the capacity when scheduling new tasks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-21909?focusedWorklogId=3D= 271675&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpa= nel#worklog-271675 ] ASF GitHub Bot logged work on HIVE-21909: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Jul/19 14:58 Start Date: 03/Jul/19 14:58 Worklog Time Spent: 10m=20 Work Description: asinkovits commented on pull request #695: HIVE-219= 09: Publish the LLAP Daemon capacity through ZooKeeper and ho=E2=80=A6 URL: https://github.com/apache/hive/pull/695#discussion_r300005231 =20 =20 ########## File path: llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/Te= stLlapDaemon.java ########## @@ -0,0 +1,111 @@ +package org.apache.hadoop.hive.llap.daemon.impl; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.llap.LlapDaemonInfo; +import org.apache.hadoop.hive.llap.daemon.rpc.LlapDaemonProtocolProtos; +import org.apache.hadoop.hive.llap.metrics.LlapMetricsSystem; +import org.apache.hadoop.hive.llap.metrics.MetricsUtils; +import org.apache.hadoop.hive.llap.registry.impl.LlapRegistryService; +import org.apache.hadoop.metrics2.MetricsSystem; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.mockito.ArgumentCaptor; +import org.mockito.Captor; +import org.mockito.Mock; +import org.mockito.Spy; +import org.mockito.internal.util.reflection.Fields; +import org.mockito.internal.util.reflection.InstanceField; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; +import java.util.stream.StreamSupport; + +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; +import static org.mockito.MockitoAnnotations.initMocks; + +public class TestLlapDaemon { + + private static final String[] METRICS_SOURCES =3D new String[]{ + "JvmMetrics", + "LlapDaemonExecutorMetrics-" + MetricsUtils.getHostName(), + "LlapDaemonJvmMetrics-" + MetricsUtils.getHostName(), + MetricsUtils.METRICS_PROCESS_NAME + }; + + @Spy =20 Review comment: Fixed. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 271675) Time Spent: 2h 10m (was: 2h) > Publish the LLAP Daemon capacity through ZooKeeper and honor the capacity= when scheduling new tasks > -------------------------------------------------------------------------= -------------------------- > > Key: HIVE-21909 > URL: https://issues.apache.org/jira/browse/HIVE-21909 > Project: Hive > Issue Type: Sub-task > Components: llap > Reporter: Peter Vary > Assignee: Antal Sinkovits > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21909.01.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The changes in LlapDaemonNode status (or executor number) should be refle= cted in the ZooKeeper information, and we should make sure TezAMs=C2=A0are = reading and honor the changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)