hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-21959) Clean up Concatenate and Msck DDL commands
Date Sun, 07 Jul 2019 23:42:00 GMT

    [ https://issues.apache.org/jira/browse/HIVE-21959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879968#comment-16879968
] 

Hive QA commented on HIVE-21959:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12973863/HIVE-21959.02.patch

{color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16329 tests executed
*Failed tests:*
{noformat}
TestDataSourceProviderFactory - did not produce a TEST-*.xml file (likely timed out) (batchId=232)
TestObjectStore - did not produce a TEST-*.xml file (likely timed out) (batchId=232)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17898/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17898/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17898/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12973863 - PreCommit-HIVE-Build

> Clean up Concatenate and Msck DDL commands
> ------------------------------------------
>
>                 Key: HIVE-21959
>                 URL: https://issues.apache.org/jira/browse/HIVE-21959
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>    Affects Versions: 3.1.1
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>              Labels: pull-request-available, refactor-ddl
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21959.01.patch, HIVE-21959.02.patch, HIVE-21959.03.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Concatenate and Msck DDL use basic data structure implementations instead of their interfaces
for variable declaration, like ArrayList instead of List, LinkedHashMap instead of Map, etc.
This is due to a lot of similar issues in the code, which needs to be cleaned.
> Concatenate also had a non-immutable Desc class, that needs to be transformed into an
immutable one. Concatenate operation code should be cut into smaller functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message